* Re: gas/config/te-sysv32.h, STRIP_UNDERSCORE
@ 2005-04-19 7:19 Jan Beulich
2005-04-19 7:42 ` Alan Modra
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2005-04-19 7:19 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]
>>> Alan Modra <amodra@bigpond.net.au> 19.04.05 07:29:35 >>>
>On Mon, Apr 18, 2005 at 04:16:12PM +0200, Jan Beulich wrote:
>> gas/config/te-sysv32.h seems to be the only file defining
>> STRIP_UNDERSCORE, and I cannot see this file getting referenced in any
>> of the configure scripts. Is this a sign that some cleanup could/should
>> be done? Jan
>
>Yes, te-sysv32.h should be deleted and reference to it in Makefile.am
>and Makefile.in removed. Patch to do that preapproved.
Applying the following patch. How about the now orphaned STRIP_UNDERSCORE then?
gas/
2005-04-19 Jan Beulich <jbeulich@novell.com>
* config/te-sysv32.h: Remove.
* Makefile.am (TARG_ENV_HFILES): Remove reference to
config/te-sysv32.h.
* Makefile.in (TARG_ENV_HFILES): Likewise.
--- src/binutils/mainline/2005-04-15/gas/config/te-sysv32.h 2000-05-14 20:53:18.000000000 +0200
+++ 2005-04-15/gas/config/te-sysv32.h 1970-01-01 01:00:00.000000000 +0100
@@ -1,6 +0,0 @@
-/* Remove leading underscore from the gcc generated symbol names. */
-#define STRIP_UNDERSCORE
-
-#include "obj-format.h"
-
-/* end of te-sysv32.h */
--- src/binutils/mainline/2005-04-15/gas/Makefile.am 2005-04-15 09:57:32.000000000 +0200
+++ 2005-04-15/gas/Makefile.am 2005-04-19 09:10:04.371846248 +0200
@@ -404,7 +404,6 @@ TARG_ENV_HFILES = \
config/te-sun3.h \
config/te-svr4.h \
config/te-symbian.h \
- config/te-sysv32.h \
config/te-tmips.h
# Multi files in config
--- src/binutils/mainline/2005-04-15/gas/Makefile.in 2005-04-15 09:57:32.000000000 +0200
+++ 2005-04-15/gas/Makefile.in 2005-04-19 09:10:09.160118320 +0200
@@ -631,7 +631,6 @@ TARG_ENV_HFILES = \
config/te-sun3.h \
config/te-svr4.h \
config/te-symbian.h \
- config/te-sysv32.h \
config/te-tmips.h
[-- Attachment #2: binutils-mainline-sysv32-remove.patch --]
[-- Type: text/plain, Size: 1183 bytes --]
gas/
2005-04-19 Jan Beulich <jbeulich@novell.com>
* config/te-sysv32.h: Remove.
* Makefile.am (TARG_ENV_HFILES): Remove reference to
config/te-sysv32.h.
* Makefile.in (TARG_ENV_HFILES): Likewise.
--- src/binutils/mainline/2005-04-15/gas/config/te-sysv32.h 2000-05-14 20:53:18.000000000 +0200
+++ 2005-04-15/gas/config/te-sysv32.h 1970-01-01 01:00:00.000000000 +0100
@@ -1,6 +0,0 @@
-/* Remove leading underscore from the gcc generated symbol names. */
-#define STRIP_UNDERSCORE
-
-#include "obj-format.h"
-
-/* end of te-sysv32.h */
--- src/binutils/mainline/2005-04-15/gas/Makefile.am 2005-04-15 09:57:32.000000000 +0200
+++ 2005-04-15/gas/Makefile.am 2005-04-19 09:10:04.371846248 +0200
@@ -404,7 +404,6 @@ TARG_ENV_HFILES = \
config/te-sun3.h \
config/te-svr4.h \
config/te-symbian.h \
- config/te-sysv32.h \
config/te-tmips.h
# Multi files in config
--- src/binutils/mainline/2005-04-15/gas/Makefile.in 2005-04-15 09:57:32.000000000 +0200
+++ 2005-04-15/gas/Makefile.in 2005-04-19 09:10:09.160118320 +0200
@@ -631,7 +631,6 @@ TARG_ENV_HFILES = \
config/te-sun3.h \
config/te-svr4.h \
config/te-symbian.h \
- config/te-sysv32.h \
config/te-tmips.h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gas/config/te-sysv32.h, STRIP_UNDERSCORE
2005-04-19 7:19 gas/config/te-sysv32.h, STRIP_UNDERSCORE Jan Beulich
@ 2005-04-19 7:42 ` Alan Modra
0 siblings, 0 replies; 6+ messages in thread
From: Alan Modra @ 2005-04-19 7:42 UTC (permalink / raw)
To: Jan Beulich; +Cc: binutils
On Tue, Apr 19, 2005 at 09:19:55AM +0200, Jan Beulich wrote:
> How about the now orphaned STRIP_UNDERSCORE then?
If you like, you can remove it. I think DO_NOT_STRIP can go too, and
the last arg of symbol_find_base. Thanks!
--
Alan Modra
IBM OzLabs - Linux Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gas/config/te-sysv32.h, STRIP_UNDERSCORE
2005-04-19 8:10 Jan Beulich
@ 2005-04-19 11:46 ` Nick Clifton
0 siblings, 0 replies; 6+ messages in thread
From: Nick Clifton @ 2005-04-19 11:46 UTC (permalink / raw)
To: Jan Beulich; +Cc: amodra, binutils
Hi Jan,
> Actually, do you think there is a need to keep symbol_find_base then at all? All symbol_find now does is call symbol_find_base...
I think Alan has gone to sleep, so I will butt in here and say "good
idea - please feel free to submit and apply a pre-approved patch to
remove symbol_find_base as well".
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gas/config/te-sysv32.h, STRIP_UNDERSCORE
@ 2005-04-19 8:10 Jan Beulich
2005-04-19 11:46 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2005-04-19 8:10 UTC (permalink / raw)
To: amodra; +Cc: binutils
>>> Alan Modra <amodra@bigpond.net.au> 19.04.05 09:42:16 >>>
>On Tue, Apr 19, 2005 at 09:19:55AM +0200, Jan Beulich wrote:
>> How about the now orphaned STRIP_UNDERSCORE then?
>
>If you like, you can remove it. I think DO_NOT_STRIP can go too, and
>the last arg of symbol_find_base. Thanks!
Actually, do you think there is a need to keep symbol_find_base then at all? All symbol_find now does is call symbol_find_base...
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gas/config/te-sysv32.h, STRIP_UNDERSCORE
2005-04-18 14:16 Jan Beulich
@ 2005-04-19 5:29 ` Alan Modra
0 siblings, 0 replies; 6+ messages in thread
From: Alan Modra @ 2005-04-19 5:29 UTC (permalink / raw)
To: Jan Beulich; +Cc: binutils
On Mon, Apr 18, 2005 at 04:16:12PM +0200, Jan Beulich wrote:
> gas/config/te-sysv32.h seems to be the only file defining
> STRIP_UNDERSCORE, and I cannot see this file getting referenced in any
> of the configure scripts. Is this a sign that some cleanup could/should
> be done? Jan
Yes, te-sysv32.h should be deleted and reference to it in Makefile.am
and Makefile.in removed. Patch to do that preapproved.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* gas/config/te-sysv32.h, STRIP_UNDERSCORE
@ 2005-04-18 14:16 Jan Beulich
2005-04-19 5:29 ` Alan Modra
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2005-04-18 14:16 UTC (permalink / raw)
To: binutils
gas/config/te-sysv32.h seems to be the only file defining STRIP_UNDERSCORE, and I cannot see this file getting referenced in any of the configure scripts. Is this a sign that some cleanup could/should be done? Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-04-19 11:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-19 7:19 gas/config/te-sysv32.h, STRIP_UNDERSCORE Jan Beulich
2005-04-19 7:42 ` Alan Modra
-- strict thread matches above, loose matches on Subject: below --
2005-04-19 8:10 Jan Beulich
2005-04-19 11:46 ` Nick Clifton
2005-04-18 14:16 Jan Beulich
2005-04-19 5:29 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).