[patch] Missing R_ARM_PLT32 cases

[patch] Missing R_ARM_PLT32 cases

[Paul Brook]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

The attached patch fixes a couple of places where we should be treating 
R_ARM_PLT32 the same as R_ARM_PC24, but don't. The the first was causing 
failures in the g++ testsuite.

Tested on arm-none-gnueabi.
Applied to binutils-csl-arm-2005q1-branch
Ok for mainline?

Paul

2005-05-01  Paul Brook  <paul@codesourcery.com>

	* elf32-arm.c (bfd_elf32_arm_process_before_allocation): Treat
	R_ARM_PLT32 the same as R_ARM_PC24.
	(arm_add_to_rel): Ditto.

[-- Attachment #2: patch.plt32 --]
[-- Type: text/x-diff, Size: 846 bytes --]

Index: bfd/elf32-arm.c
===================================================================
RCS file: /var/cvsroot/src-cvs/src/bfd/elf32-arm.c,v
retrieving revision 1.22.2.3.2.6
diff -u -p -r1.22.2.3.2.6 elf32-arm.c
--- bfd/elf32-arm.c	26 Apr 2005 05:31:38 -0000	1.22.2.3.2.6
+++ bfd/elf32-arm.c	1 May 2005 22:51:40 -0000
@@ -2393,6 +2393,7 @@ bfd_elf32_arm_process_before_allocation 
 	  switch (r_type)
 	    {
 	    case R_ARM_PC24:
+	    case R_ARM_PLT32:
 #ifndef OLD_ARM_ABI
 	    case R_ARM_CALL:
 	    case R_ARM_JUMP24:
@@ -2413,7 +2414,7 @@ bfd_elf32_arm_process_before_allocation 
 	      break;
 
 	    default:
-	      break;
+	      abort ();
 	    }
 	}
 
@@ -3993,6 +3994,7 @@ arm_add_to_rel (bfd *              abfd,
 	  break;
 
 	case R_ARM_PC24:
+	case R_ARM_PLT32:
 #ifndef OLD_ARM_ABI
 	case R_ARM_CALL:
 	case R_ARM_JUMP24:

Re: [patch] Missing R_ARM_PLT32 cases

[Daniel Jacobowitz]

On Mon, May 02, 2005 at 12:31:20AM +0100, Paul Brook wrote:
> The attached patch fixes a couple of places where we should be treating 
> R_ARM_PLT32 the same as R_ARM_PC24, but don't. The the first was causing 
> failures in the g++ testsuite.
> 
> Tested on arm-none-gnueabi.
> Applied to binutils-csl-arm-2005q1-branch
> Ok for mainline?
> 
> Paul
> 
> 2005-05-01  Paul Brook  <paul@codesourcery.com>
> 
> 	* elf32-arm.c (bfd_elf32_arm_process_before_allocation): Treat
> 	R_ARM_PLT32 the same as R_ARM_PC24.
> 	(arm_add_to_rel): Ditto.

This is sufficiently obvious that I'll approve it for HEAD.  If you
think it's important enough, you get the privilege of being
last-under-the-wire for 2.16; OK for the branch too.

-- 
Daniel Jacobowitz
CodeSourcery, LLC