From: Paul Brook <paul@codesourcery.com>
To: binutils@sources.redhat.com
Subject: [patch] Missing R_ARM_PLT32 cases
Date: Sun, 01 May 2005 23:31:00 -0000 [thread overview]
Message-ID: <200505020031.20986.paul@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
The attached patch fixes a couple of places where we should be treating
R_ARM_PLT32 the same as R_ARM_PC24, but don't. The the first was causing
failures in the g++ testsuite.
Tested on arm-none-gnueabi.
Applied to binutils-csl-arm-2005q1-branch
Ok for mainline?
Paul
2005-05-01 Paul Brook <paul@codesourcery.com>
* elf32-arm.c (bfd_elf32_arm_process_before_allocation): Treat
R_ARM_PLT32 the same as R_ARM_PC24.
(arm_add_to_rel): Ditto.
[-- Attachment #2: patch.plt32 --]
[-- Type: text/x-diff, Size: 846 bytes --]
Index: bfd/elf32-arm.c
===================================================================
RCS file: /var/cvsroot/src-cvs/src/bfd/elf32-arm.c,v
retrieving revision 1.22.2.3.2.6
diff -u -p -r1.22.2.3.2.6 elf32-arm.c
--- bfd/elf32-arm.c 26 Apr 2005 05:31:38 -0000 1.22.2.3.2.6
+++ bfd/elf32-arm.c 1 May 2005 22:51:40 -0000
@@ -2393,6 +2393,7 @@ bfd_elf32_arm_process_before_allocation
switch (r_type)
{
case R_ARM_PC24:
+ case R_ARM_PLT32:
#ifndef OLD_ARM_ABI
case R_ARM_CALL:
case R_ARM_JUMP24:
@@ -2413,7 +2414,7 @@ bfd_elf32_arm_process_before_allocation
break;
default:
- break;
+ abort ();
}
}
@@ -3993,6 +3994,7 @@ arm_add_to_rel (bfd * abfd,
break;
case R_ARM_PC24:
+ case R_ARM_PLT32:
#ifndef OLD_ARM_ABI
case R_ARM_CALL:
case R_ARM_JUMP24:
next reply other threads:[~2005-05-01 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 23:31 Paul Brook [this message]
2005-05-01 23:41 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505020031.20986.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).