From: Daniel Jacobowitz <drow@false.org>
To: Steve Ellcey <sje@cup.hp.com>
Cc: binutils@sources.redhat.com
Subject: Re: Another HP-UX IA64 Build patch
Date: Thu, 05 May 2005 17:41:00 -0000 [thread overview]
Message-ID: <20050505173236.GA17480@nevyn.them.org> (raw)
In-Reply-To: <200505051714.KAA17413@hpsje.cup.hp.com>
On Thu, May 05, 2005 at 10:14:37AM -0700, Steve Ellcey wrote:
> Here is the second of my IA64 HP-UX build patches. This one involves
> the declaration of basename() in include/libiberty.h. What do people
> think about using the prototype version whenever we are compiling with
> GCC?
>
> I did that rather than checking for HP-UX because some HP-UX systems
> (old PA ones) cannot handle the prototype but it seems like GCC should
> always be able to deal with it and it is when using GCC that "-Wall
> -Werror" will be set so I thought it might be better to check for GCC
> rather than HP-UX. Does this seem reasonable to people? Maybe we could
> remove some of the OS checks if we checked for GCC instead.
>
> Tested on IA64 HP-UX.
This is wrong. If your system headers have a conflicting prototype,
you will lose, regardless of what compiler you're using.
Do you really not have a prototype for basename?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-05-05 17:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 17:26 Steve Ellcey
2005-05-05 17:41 ` Daniel Jacobowitz [this message]
2005-05-05 17:55 ` Steve Ellcey
2005-05-05 18:12 ` James E Wilson
2005-05-05 18:16 ` Daniel Jacobowitz
2005-05-05 19:17 ` James E Wilson
2005-05-05 19:32 ` DJ Delorie
2005-05-05 19:47 ` James E Wilson
2005-05-05 21:40 ` Andreas Schwab
2005-05-05 21:43 ` DJ Delorie
2005-05-05 18:10 ` James E Wilson
2005-05-05 20:12 ` James E Wilson
2005-05-05 20:42 ` Steve Ellcey
2005-05-05 21:36 ` DJ Delorie
2005-05-05 21:41 ` James E Wilson
2005-05-05 22:46 ` DJ Delorie
2005-05-06 1:57 ` James E Wilson
2005-05-06 1:58 ` DJ Delorie
2005-05-09 23:28 ` Steve Ellcey
2005-05-09 23:33 ` DJ Delorie
2005-05-12 16:37 ` Steve Ellcey
2005-05-05 22:06 ` James E Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505173236.GA17480@nevyn.them.org \
--to=drow@false.org \
--cc=binutils@sources.redhat.com \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).