From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27955 invoked by alias); 5 May 2005 17:32:46 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27496 invoked from network); 5 May 2005 17:32:36 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 5 May 2005 17:32:36 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DTkDE-0004Yw-Bd; Thu, 05 May 2005 13:32:36 -0400 Date: Thu, 05 May 2005 17:41:00 -0000 From: Daniel Jacobowitz To: Steve Ellcey Cc: binutils@sources.redhat.com Subject: Re: Another HP-UX IA64 Build patch Message-ID: <20050505173236.GA17480@nevyn.them.org> Mail-Followup-To: Steve Ellcey , binutils@sources.redhat.com References: <200505051714.KAA17413@hpsje.cup.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505051714.KAA17413@hpsje.cup.hp.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00186.txt.bz2 On Thu, May 05, 2005 at 10:14:37AM -0700, Steve Ellcey wrote: > Here is the second of my IA64 HP-UX build patches. This one involves > the declaration of basename() in include/libiberty.h. What do people > think about using the prototype version whenever we are compiling with > GCC? > > I did that rather than checking for HP-UX because some HP-UX systems > (old PA ones) cannot handle the prototype but it seems like GCC should > always be able to deal with it and it is when using GCC that "-Wall > -Werror" will be set so I thought it might be better to check for GCC > rather than HP-UX. Does this seem reasonable to people? Maybe we could > remove some of the OS checks if we checked for GCC instead. > > Tested on IA64 HP-UX. This is wrong. If your system headers have a conflicting prototype, you will lose, regardless of what compiler you're using. Do you really not have a prototype for basename? -- Daniel Jacobowitz CodeSourcery, LLC