From: DJ Delorie <dj@redhat.com>
To: wilson@specifixinc.com
Cc: binutils@sources.redhat.com
Subject: Re: Another HP-UX IA64 Build patch
Date: Thu, 05 May 2005 19:32:00 -0000 [thread overview]
Message-ID: <200505051928.j45JSWuO026339@greed.delorie.com> (raw)
In-Reply-To: <1115316630.8413.20.camel@aretha.corp.specifixinc.com> (message from James E Wilson on Thu, 05 May 2005 11:10:30 -0700)
> > I see it doesn't have the const modifier that libiberty has. I didn't
> > get a warning or error presumbably because the build didn't include
> > libgen.h.
>
> This is a libiberty bug.
It's not supposed to be. Applications using libiberty.h need to
define HAVE_DECL_BASENAME properly. If a prototype is found in the
system headers, libiberty.h should not provide a prototype *at all*.
If the application checks and does not find any prototype, libiberty.h
should provide a full prototype.
If the application does not check, libiberty.h will provide a
K&R-style empty prototype.
All the os-specific exceptions are there because a lot of application
developers are too lazy to add the checks in all over the place
(understandable) so they special cased their OS instead. Adding to
the list is, in general, the wrong thing to do. If anything, the list
should be shrinking as applications learn to properly test for the
prototype.
next prev parent reply other threads:[~2005-05-05 19:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 17:26 Steve Ellcey
2005-05-05 17:41 ` Daniel Jacobowitz
2005-05-05 17:55 ` Steve Ellcey
2005-05-05 18:12 ` James E Wilson
2005-05-05 18:16 ` Daniel Jacobowitz
2005-05-05 19:17 ` James E Wilson
2005-05-05 19:32 ` DJ Delorie [this message]
2005-05-05 19:47 ` James E Wilson
2005-05-05 21:40 ` Andreas Schwab
2005-05-05 21:43 ` DJ Delorie
2005-05-05 18:10 ` James E Wilson
2005-05-05 20:12 ` James E Wilson
2005-05-05 20:42 ` Steve Ellcey
2005-05-05 21:36 ` DJ Delorie
2005-05-05 21:41 ` James E Wilson
2005-05-05 22:46 ` DJ Delorie
2005-05-06 1:57 ` James E Wilson
2005-05-06 1:58 ` DJ Delorie
2005-05-09 23:28 ` Steve Ellcey
2005-05-09 23:33 ` DJ Delorie
2005-05-12 16:37 ` Steve Ellcey
2005-05-05 22:06 ` James E Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505051928.j45JSWuO026339@greed.delorie.com \
--to=dj@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=wilson@specifixinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).