From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-40459-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 31298 invoked by alias); 6 May 2005 13:16:10 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 30954 invoked from network); 6 May 2005 13:15:57 -0000
Received: from unknown (HELO nevyn.them.org) (66.93.172.17)
  by sourceware.org with SMTP; 6 May 2005 13:15:57 -0000
Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian))
	id 1DU2gN-0007VU-25; Fri, 06 May 2005 09:15:55 -0400
Date: Fri, 06 May 2005 13:17:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Gwenole Beauchesne <gbeauchesne@mandriva.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Fix make -jN in bfd/doc
Message-ID: <20050506131554.GA28716@nevyn.them.org>
Mail-Followup-To: Gwenole Beauchesne <gbeauchesne@mandriva.com>,
	binutils@sources.redhat.com
References: <Pine.LNX.4.58.0505061112240.13659@thalys.mandrakesoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0505061112240.13659@thalys.mandrakesoft.com>
User-Agent: Mutt/1.5.8i
X-SW-Source: 2005-05/txt/msg00249.txt.bz2

On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> Hi,
> 
> This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
> multiple gccs were disputing chew paternity.
> 
> 2005-04-30  Gwenole Beauchesne  <gbeauchesne@mandriva.com>
> 
> 	* bfd/doc/Makefile.am: Fix dependencies on chew for parallel build.
> 	* bfd/doc/Makefile.in: Regenerate.

This patch is incorrect, since the whole point was to not have the texi
files depend on the built chew.  It sounds like we need to use a
temporary file to build chew and move it into place atomically.

> 
> --- binutils-2.16.90.0.2/bfd/doc/Makefile.in.bfd-make-chew	2005-04-29 19:50:26.000000000 +0200
> +++ binutils-2.16.90.0.2/bfd/doc/Makefile.in	2005-04-30 07:04:56.227212000 +0200
> @@ -604,115 +604,93 @@ $(srcdir)/bfd.info bfd.dvi: $(DOCFILES) 
>  # program.  If somebody tries to rebuild info, but none of the .texi files
>  # have changed, then nothing will be rebuilt.
>  
> -aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
> -	$(MAKE) $(MKDOC)
> +aoutx.texi: $(MKDOC) chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
>  	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
>  	$(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi

-- 
Daniel Jacobowitz
CodeSourcery, LLC