From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4459 invoked by alias); 6 May 2005 19:35:13 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 4440 invoked from network); 6 May 2005 19:35:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 6 May 2005 19:35:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DU8bM-00043T-9L; Fri, 06 May 2005 15:35:08 -0400 Date: Fri, 06 May 2005 19:59:00 -0000 From: Daniel Jacobowitz To: Gwenole Beauchesne , binutils@sources.redhat.com Subject: Re: [PATCH] Fix make -jN in bfd/doc Message-ID: <20050506193508.GA15556@nevyn.them.org> Mail-Followup-To: Gwenole Beauchesne , binutils@sources.redhat.com References: <20050506131554.GA28716@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050506131554.GA28716@nevyn.them.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00293.txt.bz2 On Fri, May 06, 2005 at 09:15:55AM -0400, Daniel Jacobowitz wrote: > On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote: > > Hi, > > > > This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, > > multiple gccs were disputing chew paternity. > > > > 2005-04-30 Gwenole Beauchesne > > > > * bfd/doc/Makefile.am: Fix dependencies on chew for parallel build. > > * bfd/doc/Makefile.in: Regenerate. > > This patch is incorrect, since the whole point was to not have the texi > files depend on the built chew. It sounds like we need to use a > temporary file to build chew and move it into place atomically. This patch works for me; could you give it a try? Anyone else see a problem with the new construct? -- Daniel Jacobowitz CodeSourcery, LLC Index: doc/Makefile.am =================================================================== RCS file: /home/drow/rsync/src/src/bfd/doc/Makefile.am,v retrieving revision 1.17 diff -u -p -r1.17 Makefile.am --- doc/Makefile.am 5 May 2005 15:36:03 -0000 1.17 +++ doc/Makefile.am 6 May 2005 19:30:10 -0000 @@ -57,8 +57,11 @@ MKDOC = chew$(EXEEXT_FOR_BUILD) INCLUDES = -I.. -I$(srcdir)/.. -I$(srcdir)/../../include \ -I$(srcdir)/../../intl -I../../intl -$(MKDOC): chew.o - $(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) +$(MKDOC): $(srcdir)/chew.c + $(CC_FOR_BUILD) -o chew.$$$$ $(srcdir)/chew.c \ + $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $(H_CFLAGS) \ + $(INCLUDES); \ + $(SHELL) $(srcdir)/../../move-if-change chew.$$$$ $(MKDOC) chew.o: chew.c $(CC_FOR_BUILD) -c $(INCLUDES) $(H_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/chew.c Index: doc/Makefile.in =================================================================== RCS file: /home/drow/rsync/src/src/bfd/doc/Makefile.in,v retrieving revision 1.63 diff -u -p -r1.63 Makefile.in --- doc/Makefile.in 5 May 2005 15:36:03 -0000 1.63 +++ doc/Makefile.in 6 May 2005 19:30:38 -0000 @@ -586,8 +586,11 @@ uninstall-am: uninstall uninstall-am uninstall-info-am -$(MKDOC): chew.o - $(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) +$(MKDOC): $(srcdir)/chew.c + $(CC_FOR_BUILD) -o chew.$$$$ $(srcdir)/chew.c \ + $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $(H_CFLAGS) \ + $(INCLUDES); \ + $(SHELL) $(srcdir)/../../move-if-change chew.$$$$ $(MKDOC) chew.o: chew.c $(CC_FOR_BUILD) -c $(INCLUDES) $(H_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/chew.c