From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Gwenole Beauchesne <gbeauchesne@mandriva.com>,
binutils@sources.redhat.com
Subject: Re: [PATCH] PR 878: fix -pie
Date: Sat, 07 May 2005 03:45:00 -0000 [thread overview]
Message-ID: <20050507020258.GF782@bubble.grove.modra.org> (raw)
In-Reply-To: <20050507003425.GB25928@lucon.org>
On Fri, May 06, 2005 at 05:34:25PM -0700, H. J. Lu wrote:
> On Sat, May 07, 2005 at 09:42:20AM +0930, Alan Modra wrote:
> > On Fri, May 06, 2005 at 08:42:19AM -0700, H. J. Lu wrote:
> > > - if (!link_info.relocatable && !link_info.shared)
> > > + if (link_info.executable)
> >
> > Why did you remove the relocatable test?
> >
>
> I didn't realize that we set link_info.executable for -r. How about
> this patch?
>
>
> H.J.
> ---
> 2005-05-06 H.J. Lu <hongjiu.lu@intel.com>
>
> * ldmain.c (main): Set link_info.executable to TRUE only if
> link_info.relocatable isn't.
I'd rather you just put back the link_info.relocatable test. Your patch
might be OK, but I'd guess that you haven't audited all places that test
link_info.executable.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
prev parent reply other threads:[~2005-05-07 2:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 10:33 Gwenole Beauchesne
2005-05-06 10:38 ` Jakub Jelinek
2005-05-06 15:45 ` H. J. Lu
2005-05-07 0:30 ` Alan Modra
2005-05-07 0:49 ` H. J. Lu
2005-05-07 3:45 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050507020258.GF782@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=gbeauchesne@mandriva.com \
--cc=hjl@lucon.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).