[PATCH] Fix make -jN in bfd/doc

[PATCH] Fix make -jN in bfd/doc

[Gwenole Beauchesne]

Hi,

This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
multiple gccs were disputing chew paternity.

2005-04-30  Gwenole Beauchesne  <gbeauchesne@mandriva.com>

	* bfd/doc/Makefile.am: Fix dependencies on chew for parallel build.
	* bfd/doc/Makefile.in: Regenerate.

--- binutils-2.16.90.0.2/bfd/doc/Makefile.in.bfd-make-chew	2005-04-29 19:50:26.000000000 +0200
+++ binutils-2.16.90.0.2/bfd/doc/Makefile.in	2005-04-30 07:04:56.227212000 +0200
@@ -604,115 +604,93 @@ $(srcdir)/bfd.info bfd.dvi: $(DOCFILES) 
 # program.  If somebody tries to rebuild info, but none of the .texi files
 # have changed, then nothing will be rebuilt.
 
-aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+aoutx.texi: $(MKDOC) chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
 	$(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi
 
-archive.texi: chew.c $(srcdir)/../archive.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+archive.texi: $(MKDOC) chew.c $(srcdir)/../archive.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../archive.c >archive.tmp
 	$(SHELL) $(srcdir)/../../move-if-change archive.tmp archive.texi
 
-archures.texi: chew.c $(srcdir)/../archures.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+archures.texi: $(MKDOC) chew.c $(srcdir)/../archures.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../archures.c >archures.tmp
 	$(SHELL) $(srcdir)/../../move-if-change archures.tmp archures.texi
 
 # We use bfdt.texi, rather than bfd.texi, to avoid conflicting with
 # bfd.texinfo on an 8.3 filesystem.
-bfdt.texi: chew.c $(srcdir)/../bfd.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdt.texi: $(MKDOC) chew.c $(srcdir)/../bfd.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfd.c >bfd.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfd.tmp bfdt.texi
 
-cache.texi: chew.c $(srcdir)/../cache.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+cache.texi: $(MKDOC) chew.c $(srcdir)/../cache.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../cache.c >cache.tmp
 	$(SHELL) $(srcdir)/../../move-if-change cache.tmp cache.texi
 
-coffcode.texi: chew.c $(srcdir)/../coffcode.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+coffcode.texi: $(MKDOC) chew.c $(srcdir)/../coffcode.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../coffcode.h >coffcode.tmp
 	$(SHELL) $(srcdir)/../../move-if-change coffcode.tmp coffcode.texi
 
-core.texi: chew.c $(srcdir)/../corefile.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+core.texi: $(MKDOC) chew.c $(srcdir)/../corefile.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../corefile.c >core.tmp
 	$(SHELL) $(srcdir)/../../move-if-change core.tmp core.texi
 
-elf.texi: chew.c $(srcdir)/../elf.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+elf.texi: $(MKDOC) chew.c $(srcdir)/../elf.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../elf.c >elf.tmp
 	$(SHELL) $(srcdir)/../../move-if-change elf.tmp elf.texi
 
-elfcode.texi: chew.c $(srcdir)/../elfcode.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+elfcode.texi: $(MKDOC) chew.c $(srcdir)/../elfcode.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../elfcode.h >elfcode.tmp
 	$(SHELL) $(srcdir)/../../move-if-change elfcode.tmp elfcode.texi
 
-mmo.texi: chew.c $(srcdir)/../mmo.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+mmo.texi: $(MKDOC) chew.c $(srcdir)/../mmo.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../mmo.c >mmo.tmp
 	$(SHELL) $(srcdir)/../../move-if-change mmo.tmp mmo.texi
 
-format.texi: chew.c $(srcdir)/../format.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+format.texi: $(MKDOC) chew.c $(srcdir)/../format.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../format.c >format.tmp
 	$(SHELL) $(srcdir)/../../move-if-change format.tmp format.texi
 
-libbfd.texi: chew.c $(srcdir)/../libbfd.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+libbfd.texi: $(MKDOC) chew.c $(srcdir)/../libbfd.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../libbfd.c >libbfd.tmp
 	$(SHELL) $(srcdir)/../../move-if-change libbfd.tmp libbfd.texi
 
-bfdio.texi: chew.c $(srcdir)/../bfdio.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdio.texi: $(MKDOC) chew.c $(srcdir)/../bfdio.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfdio.c >bfdio.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfdio.tmp bfdio.texi
 
-bfdwin.texi: chew.c $(srcdir)/../bfdwin.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdwin.texi: $(MKDOC) chew.c $(srcdir)/../bfdwin.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfdwin.c >bfdwin.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfdwin.tmp bfdwin.texi
 
-opncls.texi: chew.c $(srcdir)/../opncls.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+opncls.texi: $(MKDOC) chew.c $(srcdir)/../opncls.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str  <$(srcdir)/../opncls.c >opncls.tmp
 	$(SHELL) $(srcdir)/../../move-if-change opncls.tmp opncls.texi
 
-reloc.texi: chew.c $(srcdir)/../reloc.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+reloc.texi: $(MKDOC) chew.c $(srcdir)/../reloc.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../reloc.c >reloc.tmp
 	$(SHELL) $(srcdir)/../../move-if-change reloc.tmp reloc.texi
 
-section.texi: chew.c $(srcdir)/../section.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+section.texi: $(MKDOC) chew.c $(srcdir)/../section.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../section.c >section.tmp
 	$(SHELL) $(srcdir)/../../move-if-change section.tmp section.texi
 
-syms.texi: chew.c $(srcdir)/../syms.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+syms.texi: $(MKDOC) chew.c $(srcdir)/../syms.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../syms.c >syms.tmp
 	$(SHELL) $(srcdir)/../../move-if-change syms.tmp syms.texi
 
-targets.texi: chew.c $(srcdir)/../targets.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+targets.texi: $(MKDOC) chew.c $(srcdir)/../targets.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../targets.c >targets.tmp
 	$(SHELL) $(srcdir)/../../move-if-change targets.tmp targets.texi
 
-init.texi: chew.c $(srcdir)/../init.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+init.texi: $(MKDOC) chew.c $(srcdir)/../init.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../init.c >init.tmp
 	$(SHELL) $(srcdir)/../../move-if-change init.tmp init.texi
 
-hash.texi: chew.c $(srcdir)/../hash.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+hash.texi: $(MKDOC) chew.c $(srcdir)/../hash.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../hash.c >hash.tmp
 	$(SHELL) $(srcdir)/../../move-if-change hash.tmp hash.texi
 
-linker.texi: chew.c $(srcdir)/../linker.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+linker.texi: $(MKDOC) chew.c $(srcdir)/../linker.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../linker.c >linker.tmp
 	$(SHELL) $(srcdir)/../../move-if-change linker.tmp linker.texi
 
--- binutils-2.16.90.0.2/bfd/doc/Makefile.am.bfd-make-chew	2005-04-29 19:50:26.000000000 +0200
+++ binutils-2.16.90.0.2/bfd/doc/Makefile.am	2005-04-30 07:02:43.643261209 +0200
@@ -75,115 +75,93 @@ $(srcdir)/bfd.info bfd.dvi: $(DOCFILES) 
 # program.  If somebody tries to rebuild info, but none of the .texi files
 # have changed, then nothing will be rebuilt.
 
-aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+aoutx.texi: $(MKDOC) chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
 	$(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi
 
-archive.texi: chew.c $(srcdir)/../archive.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+archive.texi: $(MKDOC) chew.c $(srcdir)/../archive.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../archive.c >archive.tmp
 	$(SHELL) $(srcdir)/../../move-if-change archive.tmp archive.texi
 
-archures.texi: chew.c $(srcdir)/../archures.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+archures.texi: $(MKDOC) chew.c $(srcdir)/../archures.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../archures.c >archures.tmp
 	$(SHELL) $(srcdir)/../../move-if-change archures.tmp archures.texi
 
 # We use bfdt.texi, rather than bfd.texi, to avoid conflicting with
 # bfd.texinfo on an 8.3 filesystem.
-bfdt.texi: chew.c $(srcdir)/../bfd.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdt.texi: $(MKDOC) chew.c $(srcdir)/../bfd.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfd.c >bfd.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfd.tmp bfdt.texi
 
-cache.texi: chew.c $(srcdir)/../cache.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+cache.texi: $(MKDOC) chew.c $(srcdir)/../cache.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../cache.c >cache.tmp
 	$(SHELL) $(srcdir)/../../move-if-change cache.tmp cache.texi
 
-coffcode.texi: chew.c $(srcdir)/../coffcode.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+coffcode.texi: $(MKDOC) chew.c $(srcdir)/../coffcode.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../coffcode.h >coffcode.tmp
 	$(SHELL) $(srcdir)/../../move-if-change coffcode.tmp coffcode.texi
 
-core.texi: chew.c $(srcdir)/../corefile.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+core.texi: $(MKDOC) chew.c $(srcdir)/../corefile.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../corefile.c >core.tmp
 	$(SHELL) $(srcdir)/../../move-if-change core.tmp core.texi
 
-elf.texi: chew.c $(srcdir)/../elf.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+elf.texi: $(MKDOC) chew.c $(srcdir)/../elf.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../elf.c >elf.tmp
 	$(SHELL) $(srcdir)/../../move-if-change elf.tmp elf.texi
 
-elfcode.texi: chew.c $(srcdir)/../elfcode.h $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+elfcode.texi: $(MKDOC) chew.c $(srcdir)/../elfcode.h $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../elfcode.h >elfcode.tmp
 	$(SHELL) $(srcdir)/../../move-if-change elfcode.tmp elfcode.texi
 
-mmo.texi: chew.c $(srcdir)/../mmo.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+mmo.texi: $(MKDOC) chew.c $(srcdir)/../mmo.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../mmo.c >mmo.tmp
 	$(SHELL) $(srcdir)/../../move-if-change mmo.tmp mmo.texi
 
-format.texi: chew.c $(srcdir)/../format.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+format.texi: $(MKDOC) chew.c $(srcdir)/../format.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../format.c >format.tmp
 	$(SHELL) $(srcdir)/../../move-if-change format.tmp format.texi
 
-libbfd.texi: chew.c $(srcdir)/../libbfd.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+libbfd.texi: $(MKDOC) chew.c $(srcdir)/../libbfd.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../libbfd.c >libbfd.tmp
 	$(SHELL) $(srcdir)/../../move-if-change libbfd.tmp libbfd.texi
 
-bfdio.texi: chew.c $(srcdir)/../bfdio.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdio.texi: $(MKDOC) chew.c $(srcdir)/../bfdio.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfdio.c >bfdio.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfdio.tmp bfdio.texi
 
-bfdwin.texi: chew.c $(srcdir)/../bfdwin.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+bfdwin.texi: $(MKDOC) chew.c $(srcdir)/../bfdwin.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str < $(srcdir)/../bfdwin.c >bfdwin.tmp
 	$(SHELL) $(srcdir)/../../move-if-change bfdwin.tmp bfdwin.texi
 
-opncls.texi: chew.c $(srcdir)/../opncls.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+opncls.texi: $(MKDOC) chew.c $(srcdir)/../opncls.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str  <$(srcdir)/../opncls.c >opncls.tmp
 	$(SHELL) $(srcdir)/../../move-if-change opncls.tmp opncls.texi
 
-reloc.texi: chew.c $(srcdir)/../reloc.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+reloc.texi: $(MKDOC) chew.c $(srcdir)/../reloc.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../reloc.c >reloc.tmp
 	$(SHELL) $(srcdir)/../../move-if-change reloc.tmp reloc.texi
 
-section.texi: chew.c $(srcdir)/../section.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+section.texi: $(MKDOC) chew.c $(srcdir)/../section.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../section.c >section.tmp
 	$(SHELL) $(srcdir)/../../move-if-change section.tmp section.texi
 
-syms.texi: chew.c $(srcdir)/../syms.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+syms.texi: $(MKDOC) chew.c $(srcdir)/../syms.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../syms.c >syms.tmp
 	$(SHELL) $(srcdir)/../../move-if-change syms.tmp syms.texi
 
-targets.texi: chew.c $(srcdir)/../targets.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+targets.texi: $(MKDOC) chew.c $(srcdir)/../targets.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../targets.c >targets.tmp
 	$(SHELL) $(srcdir)/../../move-if-change targets.tmp targets.texi
 
-init.texi: chew.c $(srcdir)/../init.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+init.texi: $(MKDOC) chew.c $(srcdir)/../init.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../init.c >init.tmp
 	$(SHELL) $(srcdir)/../../move-if-change init.tmp init.texi
 
-hash.texi: chew.c $(srcdir)/../hash.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+hash.texi: $(MKDOC) chew.c $(srcdir)/../hash.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../hash.c >hash.tmp
 	$(SHELL) $(srcdir)/../../move-if-change hash.tmp hash.texi
 
-linker.texi: chew.c $(srcdir)/../linker.c $(srcdir)/doc.str
-	$(MAKE) $(MKDOC)
+linker.texi: $(MKDOC) chew.c $(srcdir)/../linker.c $(srcdir)/doc.str
 	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../linker.c >linker.tmp
 	$(SHELL) $(srcdir)/../../move-if-change linker.tmp linker.texi
 

Re: [PATCH] Fix make -jN in bfd/doc

[Daniel Jacobowitz]

On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> Hi,
> 
> This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
> multiple gccs were disputing chew paternity.
> 
> 2005-04-30  Gwenole Beauchesne  <gbeauchesne@mandriva.com>
> 
> 	* bfd/doc/Makefile.am: Fix dependencies on chew for parallel build.
> 	* bfd/doc/Makefile.in: Regenerate.

This patch is incorrect, since the whole point was to not have the texi
files depend on the built chew.  It sounds like we need to use a
temporary file to build chew and move it into place atomically.

> 
> --- binutils-2.16.90.0.2/bfd/doc/Makefile.in.bfd-make-chew	2005-04-29 19:50:26.000000000 +0200
> +++ binutils-2.16.90.0.2/bfd/doc/Makefile.in	2005-04-30 07:04:56.227212000 +0200
> @@ -604,115 +604,93 @@ $(srcdir)/bfd.info bfd.dvi: $(DOCFILES) 
>  # program.  If somebody tries to rebuild info, but none of the .texi files
>  # have changed, then nothing will be rebuilt.
>  
> -aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
> -	$(MAKE) $(MKDOC)
> +aoutx.texi: $(MKDOC) chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
>  	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
>  	$(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [PATCH] Fix make -jN in bfd/doc

[H. J. Lu]

On Fri, May 06, 2005 at 09:15:55AM -0400, Daniel Jacobowitz wrote:
> On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> > Hi,
> > 
> > This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
> > multiple gccs were disputing chew paternity.
> > 

I couldn't find ChangeLog entries in bfd/ChangeLog nor bfd/doc/ChangeLog
for

http://sourceware.org/ml/binutils/2005-04/msg00800.html

Did I miss them?


H.J.

Re: [PATCH] Fix make -jN in bfd/doc

[Daniel Jacobowitz]

On Fri, May 06, 2005 at 06:53:09AM -0700, H. J. Lu wrote:
> On Fri, May 06, 2005 at 09:15:55AM -0400, Daniel Jacobowitz wrote:
> > On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> > > Hi,
> > > 
> > > This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
> > > multiple gccs were disputing chew paternity.
> > > 
> 
> I couldn't find ChangeLog entries in bfd/ChangeLog nor bfd/doc/ChangeLog
> for
> 
> http://sourceware.org/ml/binutils/2005-04/msg00800.html
> 
> Did I miss them?

Wow, I've seriously goofed that up.  I put the changelog entries in
bfd/ChangeLog instead of bfd/doc/ChangeLog on the branch, and I missed
the ChangeLog entirely on HEAD.

I don't have time to fix it right now, but I will be sure to do it
later or this weekend.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [PATCH] Fix make -jN in bfd/doc

[Daniel Jacobowitz]

On Fri, May 06, 2005 at 09:15:55AM -0400, Daniel Jacobowitz wrote:
> On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> > Hi,
> > 
> > This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise, 
> > multiple gccs were disputing chew paternity.
> > 
> > 2005-04-30  Gwenole Beauchesne  <gbeauchesne@mandriva.com>
> > 
> > 	* bfd/doc/Makefile.am: Fix dependencies on chew for parallel build.
> > 	* bfd/doc/Makefile.in: Regenerate.
> 
> This patch is incorrect, since the whole point was to not have the texi
> files depend on the built chew.  It sounds like we need to use a
> temporary file to build chew and move it into place atomically.

This patch works for me; could you give it a try?  Anyone else see a
problem with the new construct?

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Index: doc/Makefile.am
===================================================================
RCS file: /home/drow/rsync/src/src/bfd/doc/Makefile.am,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile.am
--- doc/Makefile.am	5 May 2005 15:36:03 -0000	1.17
+++ doc/Makefile.am	6 May 2005 19:30:10 -0000
@@ -57,8 +57,11 @@ MKDOC = chew$(EXEEXT_FOR_BUILD)
 INCLUDES = -I.. -I$(srcdir)/.. -I$(srcdir)/../../include \
 	-I$(srcdir)/../../intl -I../../intl
 
-$(MKDOC): chew.o
-	$(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD)
+$(MKDOC): $(srcdir)/chew.c
+	$(CC_FOR_BUILD) -o chew.$$$$ $(srcdir)/chew.c \
+	  $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $(H_CFLAGS) \
+	  $(INCLUDES); \
+	$(SHELL) $(srcdir)/../../move-if-change chew.$$$$ $(MKDOC)
 
 chew.o: chew.c
 	$(CC_FOR_BUILD) -c $(INCLUDES) $(H_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/chew.c
Index: doc/Makefile.in
===================================================================
RCS file: /home/drow/rsync/src/src/bfd/doc/Makefile.in,v
retrieving revision 1.63
diff -u -p -r1.63 Makefile.in
--- doc/Makefile.in	5 May 2005 15:36:03 -0000	1.63
+++ doc/Makefile.in	6 May 2005 19:30:38 -0000
@@ -586,8 +586,11 @@ uninstall-am:
 	uninstall uninstall-am uninstall-info-am
 
 
-$(MKDOC): chew.o
-	$(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD)
+$(MKDOC): $(srcdir)/chew.c
+	$(CC_FOR_BUILD) -o chew.$$$$ $(srcdir)/chew.c \
+	  $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $(H_CFLAGS) \
+	  $(INCLUDES); \
+	$(SHELL) $(srcdir)/../../move-if-change chew.$$$$ $(MKDOC)
 
 chew.o: chew.c
 	$(CC_FOR_BUILD) -c $(INCLUDES) $(H_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/chew.c

Re: [PATCH] Fix make -jN in bfd/doc

[Gwenole Beauchesne]

Le vendredi, 6 mai 2005, à 21:35 Europe/Paris, Daniel Jacobowitz a 
écrit :

> This patch works for me; could you give it a try?

It works for me too. Thanks.

Re: [PATCH] Fix make -jN in bfd/doc

[Daniel Jacobowitz]

On Fri, May 06, 2005 at 11:55:50PM +0200, Gwenole Beauchesne wrote:
> Le vendredi, 6 mai 2005, à 21:35 Europe/Paris, Daniel Jacobowitz a 
> écrit :
> 
> >This patch works for me; could you give it a try?
> 
> It works for me too. Thanks.

I've checked this in to HEAD and the 2.16 branch.  I don't know if
there will be a binutils 2.16.1; if no other problems turn up in the
next month or two, probably not.  But if there is, it will include ths
fix.

Thanks for the report.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

2.16.1 candidate patches

[Alan Modra]

On Mon, May 09, 2005 at 05:15:27PM -0400, Daniel Jacobowitz wrote:
> I've checked this in to HEAD and the 2.16 branch.  I don't know if
> there will be a binutils 2.16.1; if no other problems turn up in the
> next month or two, probably not.  But if there is, it will include ths
> fix.

I'm putting http://sources.redhat.com/ml/binutils/2005-05/msg00340.html
and http://sources.redhat.com/ml/binutils/2005-04/msg00007.html plus
http://sources.redhat.com/ml/binutils/2005-04/msg00121.html on the
branch too.  The first one is important enough to roll 2.16.1 for
powerpc64 (or at least anyone using 2.16 and gcc-3.4 on powerpc64 will
want the patch).  I'm an idiot because I had a problem report in early
April but discounted it because I couldn't reproduce it, forgetting that
my local gcc-3.4 was patched to not use dot-syms.  The other two patches
just got forgotten but aren't critical in any way.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: 2.16.1 candidate patches

[The Doctor]

On Tue, May 10, 2005 at 09:58:12AM +0930, Alan Modra wrote:
> On Mon, May 09, 2005 at 05:15:27PM -0400, Daniel Jacobowitz wrote:
> > I've checked this in to HEAD and the 2.16 branch.  I don't know if
> > there will be a binutils 2.16.1; if no other problems turn up in the
> > next month or two, probably not.  But if there is, it will include ths
> > fix.
> 
> I'm putting http://sources.redhat.com/ml/binutils/2005-05/msg00340.html
> and http://sources.redhat.com/ml/binutils/2005-04/msg00007.html plus
> http://sources.redhat.com/ml/binutils/2005-04/msg00121.html on the
> branch too.  The first one is important enough to roll 2.16.1 for
> powerpc64 (or at least anyone using 2.16 and gcc-3.4 on powerpc64 will
> want the patch).  I'm an idiot because I had a problem report in early
> April but discounted it because I couldn't reproduce it, forgetting that
> my local gcc-3.4 was patched to not use dot-syms.  The other two patches
> just got forgotten but aren't critical in any way.
>

Add to that

as: unrecognized option `-Qy'

This was working under 2.15 .  What happened under 2.16?
 
> -- 
> Alan Modra
> IBM OzLabs - Linux Technology Centre

-- 
Member - Liberal International	
This is doctor@nl2k.ab.ca	Ici doctor@nl2k.ab.ca
God Queen and country! Beware Anti-Christ rising!
BC, Vote Liberal!!

Re: 2.16.1 candidate patches

[Alan Modra]

On Mon, May 09, 2005 at 07:06:07PM -0600, The Doctor wrote:
> as: unrecognized option `-Qy'
> 
> This was working under 2.15 .  What happened under 2.16?

Target?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: 2.16.1 candidate patches

[Mike Frysinger]

On Monday 09 May 2005 08:28 pm, Alan Modra wrote:
> On Mon, May 09, 2005 at 05:15:27PM -0400, Daniel Jacobowitz wrote:
> > I've checked this in to HEAD and the 2.16 branch.  I don't know if
> > there will be a binutils 2.16.1; if no other problems turn up in the
> > next month or two, probably not.  But if there is, it will include ths
> > fix.
>
> I'm putting http://sources.redhat.com/ml/binutils/2005-05/msg00340.html
> and http://sources.redhat.com/ml/binutils/2005-04/msg00007.html plus
> http://sources.redhat.com/ml/binutils/2005-04/msg00121.html on the
> branch too.  The first one is important enough to roll 2.16.1 for
> powerpc64 (or at least anyone using 2.16 and gcc-3.4 on powerpc64 will
> want the patch).  I'm an idiot because I had a problem report in early
> April but discounted it because I couldn't reproduce it, forgetting that
> my local gcc-3.4 was patched to not use dot-syms.  The other two patches
> just got forgotten but aren't critical in any way.

how about this little patch for ARM ?
http://sourceware.org/ml/binutils/2005-05/msg00146.html
-mike

Re: 2.16.1 candidate patches

[The Doctor]

On Tue, May 10, 2005 at 10:52:35AM +0930, Alan Modra wrote:
> On Mon, May 09, 2005 at 07:06:07PM -0600, The Doctor wrote:
> > as: unrecognized option `-Qy'
> > 
> > This was working under 2.15 .  What happened under 2.16?
> 
> Target?
>

i386-unknown-bsdi
 
> -- 
> Alan Modra
> IBM OzLabs - Linux Technology Centre

-- 
Member - Liberal International	
This is doctor@nl2k.ab.ca	Ici doctor@nl2k.ab.ca
God Queen and country! Beware Anti-Christ rising!
BC, Vote Liberal!!

Re: 2.16.1 candidate patches

[Alan Modra]

On Mon, May 09, 2005 at 08:48:23PM -0600, The Doctor wrote:
> On Tue, May 10, 2005 at 10:52:35AM +0930, Alan Modra wrote:
> > On Mon, May 09, 2005 at 07:06:07PM -0600, The Doctor wrote:
> > > as: unrecognized option `-Qy'
> > > 
> > > This was working under 2.15 .  What happened under 2.16?
> > 
> > Target?
> >
> i386-unknown-bsdi

I think you must have configured 2.15 differently from 2.16.

i386-*-bsdi is AOUT, so should not have support for -Q (see
tc-i386.c:md_parse_option).  However, x86 gas is one of the few gas
targets that support multiple output formats, so I'm guessing that you
used --enable-targets=all (or specifically selected an x86 elf target)
on 2.15 but not on 2.16.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: 2.16.1 candidate patches

[The Doctor]

On Wed, May 11, 2005 at 09:55:34AM +0930, Alan Modra wrote:
> On Mon, May 09, 2005 at 08:48:23PM -0600, The Doctor wrote:
> > On Tue, May 10, 2005 at 10:52:35AM +0930, Alan Modra wrote:
> > > On Mon, May 09, 2005 at 07:06:07PM -0600, The Doctor wrote:
> > > > as: unrecognized option `-Qy'
> > > > 
> > > > This was working under 2.15 .  What happened under 2.16?
> > > 
> > > Target?
> > >
> > i386-unknown-bsdi
> 
> I think you must have configured 2.15 differently from 2.16.
> 
> i386-*-bsdi is AOUT, so should not have support for -Q (see
> tc-i386.c:md_parse_option).  However, x86 gas is one of the few gas
> targets that support multiple output formats, so I'm guessing that you
> used --enable-targets=all (or specifically selected an x86 elf target)
> on 2.15 but not on 2.16.
>

I have a patch which make i386-*-bsdi elf compliant.

If you want, I can send the patch to you to inspect.
 
> -- 
> Alan Modra
> IBM OzLabs - Linux Technology Centre

-- 
Member - Liberal International	
This is doctor@nl2k.ab.ca	Ici doctor@nl2k.ab.ca
God Queen and country! Beware Anti-Christ rising!
BC, Vote Liberal!!

Re: 2.16.1 candidate patches

[Daniel Jacobowitz]

On Mon, May 09, 2005 at 09:46:42PM -0400, Mike Frysinger wrote:
> On Monday 09 May 2005 08:28 pm, Alan Modra wrote:
> > On Mon, May 09, 2005 at 05:15:27PM -0400, Daniel Jacobowitz wrote:
> > > I've checked this in to HEAD and the 2.16 branch.  I don't know if
> > > there will be a binutils 2.16.1; if no other problems turn up in the
> > > next month or two, probably not.  But if there is, it will include ths
> > > fix.
> >
> > I'm putting http://sources.redhat.com/ml/binutils/2005-05/msg00340.html
> > and http://sources.redhat.com/ml/binutils/2005-04/msg00007.html plus
> > http://sources.redhat.com/ml/binutils/2005-04/msg00121.html on the
> > branch too.  The first one is important enough to roll 2.16.1 for
> > powerpc64 (or at least anyone using 2.16 and gcc-3.4 on powerpc64 will
> > want the patch).  I'm an idiot because I had a problem report in early
> > April but discounted it because I couldn't reproduce it, forgetting that
> > my local gcc-3.4 was patched to not use dot-syms.  The other two patches
> > just got forgotten but aren't critical in any way.
> 
> how about this little patch for ARM ?
> http://sourceware.org/ml/binutils/2005-05/msg00146.html

I've merged that.  I'm going to wait until next week, and then create
2.16.1.

-- 
Daniel Jacobowitz
CodeSourcery, LLC