From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: carlos@systemhalted.org (Carlos O'Donell)
Cc: binutils@sources.redhat.com, dave.anglin@nrc-cnrc.gc.ca,
tausq@debian.org
Subject: Re: [PATCH] Naming consistency in bfd/elf32-hppa.c
Date: Tue, 21 Jun 2005 14:22:00 -0000 [thread overview]
Message-ID: <200506211421.j5LELpf4011490@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20050620182216.GA5269@systemhalted.org> from "Carlos O'Donell" at Jun 20, 2005 02:22:29 pm
> Please apply.
>
> 2005-06-20 Carlos O'Donell <carlos@systemhalted.org>
>
> * bfd/elf32-hppa.c (hppa_elf_hash_entry): Define.
> (hppa_stub_hash_entry): Define.
> (stub_hash_newfunc): Rename variables.
> (hppa_link_hash_newfunc): Likewise.
> (elf32_hppa_link_hash_table_free): Likewise.
> (hppa_stub_name): Likewise.
> (hppa_get_stub_entry): Likewise.
> (hppa_add_stub): Likewise.
> (hppa_type_of_stub): Likewise.
> (hppa_build_one_stub): Likewise.
> (hppa_size_one_stub): Likewise.
> (elf32_hppa_create_dynamic_sections): Likewise.
> (elf32_hppa_copy_indirect_symbol): Likewise.
> (elf32_hppa_check_relocs): Likewise.
> (elf32_hppa_gc_mark_hook): Likewise.
> (elf32_hppa_gc_sweep_hook): Likewise.
> (elf32_hppa_grok_psinfo): Likewise.
> (elf32_hppa_hide_symbol): Likewise.
> (elf32_hppa_adjust_dynamic_symbol): Likewise.
> (allocate_dynrelocs): Likewise.
> (clobber_millicode_symbols): Likewise.
> (readonly_dynrelocs): Likewise.
> (elf32_hppa_size_dynamic_sections): Likewise.
> (get_local_syms): Likewise.
> (elf32_hppa_size_stubs): Likewise.
> (hppa_record_segment_addr): Likewise.
> (final_link_relocate): Likewise.
> (elf32_hppa_relocate_section): Likewise.
> (elf32_hppa_finish_dynamic_symbol): Likewise.
Installed.
As noted in private mail, there are some struct field names could be
updated to follow your naming convention. For example,
/* The symbol table entry, if any, that this was derived from. */
struct elf32_hppa_link_hash_entry *h;
to
/* The symbol table entry, if any, that this was derived from. */
struct elf32_hppa_link_hash_entry *hh;
It would be greatly appreciated if these could be updated as well.
Thanks,
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
next prev parent reply other threads:[~2005-06-21 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 18:23 Carlos O'Donell
2005-06-21 14:22 ` John David Anglin [this message]
2005-06-27 15:22 ` [PATCH] Naming consistency in bfd/elf32-hppa.c (Round 2) Carlos O'Donell
2005-06-27 23:55 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506211421.j5LELpf4011490@hiauly1.hia.nrc.ca \
--to=dave@hiauly1.hia.nrc.ca \
--cc=binutils@sources.redhat.com \
--cc=carlos@systemhalted.org \
--cc=dave.anglin@nrc-cnrc.gc.ca \
--cc=tausq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).