From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25722 invoked by alias); 21 Jun 2005 14:22:15 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 25436 invoked by uid 22791); 21 Jun 2005 14:22:01 -0000 Received: from hiauly1.hia.nrc.ca (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 21 Jun 2005 14:22:01 +0000 Received: from hiauly1.hia.nrc.ca (hiauly1.hia.nrc.ca [127.0.0.1] (may be forged)) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9) with ESMTP id j5LELqnV011491; Tue, 21 Jun 2005 10:21:52 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9/Submit) id j5LELpf4011490; Tue, 21 Jun 2005 10:21:51 -0400 (EDT) Message-Id: <200506211421.j5LELpf4011490@hiauly1.hia.nrc.ca> Subject: Re: [PATCH] Naming consistency in bfd/elf32-hppa.c To: carlos@systemhalted.org (Carlos O'Donell) Date: Tue, 21 Jun 2005 14:22:00 -0000 From: "John David Anglin" Cc: binutils@sources.redhat.com, dave.anglin@nrc-cnrc.gc.ca, tausq@debian.org In-Reply-To: <20050620182216.GA5269@systemhalted.org> from "Carlos O'Donell" at Jun 20, 2005 02:22:29 pm MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-06/txt/msg00530.txt.bz2 > Please apply. > > 2005-06-20 Carlos O'Donell > > * bfd/elf32-hppa.c (hppa_elf_hash_entry): Define. > (hppa_stub_hash_entry): Define. > (stub_hash_newfunc): Rename variables. > (hppa_link_hash_newfunc): Likewise. > (elf32_hppa_link_hash_table_free): Likewise. > (hppa_stub_name): Likewise. > (hppa_get_stub_entry): Likewise. > (hppa_add_stub): Likewise. > (hppa_type_of_stub): Likewise. > (hppa_build_one_stub): Likewise. > (hppa_size_one_stub): Likewise. > (elf32_hppa_create_dynamic_sections): Likewise. > (elf32_hppa_copy_indirect_symbol): Likewise. > (elf32_hppa_check_relocs): Likewise. > (elf32_hppa_gc_mark_hook): Likewise. > (elf32_hppa_gc_sweep_hook): Likewise. > (elf32_hppa_grok_psinfo): Likewise. > (elf32_hppa_hide_symbol): Likewise. > (elf32_hppa_adjust_dynamic_symbol): Likewise. > (allocate_dynrelocs): Likewise. > (clobber_millicode_symbols): Likewise. > (readonly_dynrelocs): Likewise. > (elf32_hppa_size_dynamic_sections): Likewise. > (get_local_syms): Likewise. > (elf32_hppa_size_stubs): Likewise. > (hppa_record_segment_addr): Likewise. > (final_link_relocate): Likewise. > (elf32_hppa_relocate_section): Likewise. > (elf32_hppa_finish_dynamic_symbol): Likewise. Installed. As noted in private mail, there are some struct field names could be updated to follow your naming convention. For example, /* The symbol table entry, if any, that this was derived from. */ struct elf32_hppa_link_hash_entry *h; to /* The symbol table entry, if any, that this was derived from. */ struct elf32_hppa_link_hash_entry *hh; It would be greatly appreciated if these could be updated as well. Thanks, Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602)