From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: Re: [patch] PPC small data symbols.
Date: Tue, 12 Jul 2005 11:25:00 -0000 [thread overview]
Message-ID: <20050712112522.GJ30960@bubble.grove.modra.org> (raw)
In-Reply-To: <200506290222.40944.paul@codesourcery.com>
On Wed, Jun 29, 2005 at 02:22:40AM +0100, Paul Brook wrote:
> * elf32-ppc.c (ppc_elf_set_sdata_syms): Make sdata symbols section
> relative.
This slipped past my review.
* elf32-ppc.c (ppc_elf_set_sdata_syms): Correct __sbss_start value.
Index: bfd/elf32-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-ppc.c,v
retrieving revision 1.171
diff -u -p -r1.171 elf32-ppc.c
--- bfd/elf32-ppc.c 8 Jul 2005 06:19:59 -0000 1.171
+++ bfd/elf32-ppc.c 12 Jul 2005 09:40:43 -0000
@@ -5307,12 +5311,11 @@ ppc_elf_set_sdata_syms (bfd *obfd, struc
}
s = bfd_get_section_by_name (obfd, ".sbss");
- _bfd_elf_provide_symbol (info, "__sbss_start", 0, NULL);
- _bfd_elf_provide_symbol (info, "___sbss_start", 0, NULL);
+ val = 0;
+ _bfd_elf_provide_symbol (info, "__sbss_start", val, s);
+ _bfd_elf_provide_symbol (info, "___sbss_start", val, s);
if (s != NULL)
val = s->size;
- else
- val = 0;
_bfd_elf_provide_symbol (info, "__sbss_end", val, s);
_bfd_elf_provide_symbol (info, "___sbss_end", val, s);
return TRUE;
--
Alan Modra
IBM OzLabs - Linux Technology Centre
prev parent reply other threads:[~2005-07-12 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 1:22 Paul Brook
2005-06-29 6:47 ` Alan Modra
2005-07-12 11:25 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050712112522.GJ30960@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).