From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15820 invoked by alias); 12 Jul 2005 11:25:54 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 15768 invoked by uid 22791); 12 Jul 2005 11:25:47 -0000 Received: from omta01sl.mx.bigpond.com (HELO omta01sl.mx.bigpond.com) (144.140.92.153) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 12 Jul 2005 11:25:47 +0000 Received: from grove.modra.org ([144.136.167.90]) by omta01sl.mx.bigpond.com with ESMTP id <20050712112525.OXCV5164.omta01sl.mx.bigpond.com@grove.modra.org> for ; Tue, 12 Jul 2005 11:25:25 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 7E2041A1158; Tue, 12 Jul 2005 20:55:22 +0930 (CST) Date: Tue, 12 Jul 2005 11:25:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: Re: [patch] PPC small data symbols. Message-ID: <20050712112522.GJ30960@bubble.grove.modra.org> Mail-Followup-To: binutils@sources.redhat.com References: <200506290222.40944.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200506290222.40944.paul@codesourcery.com> User-Agent: Mutt/1.4i X-SW-Source: 2005-07/txt/msg00231.txt.bz2 On Wed, Jun 29, 2005 at 02:22:40AM +0100, Paul Brook wrote: > * elf32-ppc.c (ppc_elf_set_sdata_syms): Make sdata symbols section > relative. This slipped past my review. * elf32-ppc.c (ppc_elf_set_sdata_syms): Correct __sbss_start value. Index: bfd/elf32-ppc.c =================================================================== RCS file: /cvs/src/src/bfd/elf32-ppc.c,v retrieving revision 1.171 diff -u -p -r1.171 elf32-ppc.c --- bfd/elf32-ppc.c 8 Jul 2005 06:19:59 -0000 1.171 +++ bfd/elf32-ppc.c 12 Jul 2005 09:40:43 -0000 @@ -5307,12 +5311,11 @@ ppc_elf_set_sdata_syms (bfd *obfd, struc } s = bfd_get_section_by_name (obfd, ".sbss"); - _bfd_elf_provide_symbol (info, "__sbss_start", 0, NULL); - _bfd_elf_provide_symbol (info, "___sbss_start", 0, NULL); + val = 0; + _bfd_elf_provide_symbol (info, "__sbss_start", val, s); + _bfd_elf_provide_symbol (info, "___sbss_start", val, s); if (s != NULL) val = s->size; - else - val = 0; _bfd_elf_provide_symbol (info, "__sbss_end", val, s); _bfd_elf_provide_symbol (info, "___sbss_end", val, s); return TRUE; -- Alan Modra IBM OzLabs - Linux Technology Centre