public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix some FAILs in MIPS ld testsuite.
@ 2005-08-18  1:02 David Daney
  2005-08-18  7:51 ` Thiemo Seufer
  0 siblings, 1 reply; 2+ messages in thread
From: David Daney @ 2005-08-18  1:02 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Some recent changes to ld including, but not necessarily limited to:

http://sourceware.org/ml/binutils/2005-05/msg00712.html

Have caused some testsuite failures for the MIPS target.  For the five 
tests covered by the attached patch the problem is in the testsuite.

There are other FAILures that I think are likley to be erroneously 
caused by problems in the testsuite (mostly TLS related), but I am not 
sure about those so I didn't fix them.

The attached patch fixes five FAILs.

2005-08-17  David Daney  <ddaney@avtrex.com>

	* ld-mips-elf/multi-got-1.d: Adjust for new ld behavior.
	* ld-mips-elf/multi-got-no-shared.d: Ditto.
	* ld-mips-elf/rel32-n32.d: Ditto.
	* ld-mips-elf/rel32-o32.d: Ditto.
	* ld-mips-elf/rel64.d: Ditto.


OK to commit?

David Daney

[-- Attachment #2: ldtests.d --]
[-- Type: text/plain, Size: 5887 bytes --]

Index: ld-mips-elf/multi-got-1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/multi-got-1.d,v
retrieving revision 1.5
diff -u -r1.5 multi-got-1.d
--- ld-mips-elf/multi-got-1.d	31 Jan 2005 22:00:59 -0000	1.5
+++ ld-mips-elf/multi-got-1.d	18 Aug 2005 00:46:08 -0000
@@ -10,7 +10,7 @@
  0x00000004 \(HASH\)                       0x184
  0x00000005 \(STRTAB\)                     0x[0-9a-f]+
  0x00000006 \(SYMTAB\)                     0x[0-9a-f]+
- 0x0000000a \(STRSZ\)                      178090 \(bytes\)
+ 0x0000000a \(STRSZ\)                      [0-9]+ \(bytes\)
  0x0000000b \(SYMENT\)                     16 \(bytes\)
  0x00000015 \(DEBUG\)                      0x0
  0x00000003 \(PLTGOT\)                     0x[0-9a-f]+
@@ -21,9 +21,9 @@
  0x70000005 \(MIPS_FLAGS\)                 NOTPOT
  0x70000006 \(MIPS_BASE_ADDRESS\)          0
  0x7000000a \(MIPS_LOCAL_GOTNO\)           12
- 0x70000011 \(MIPS_SYMTABNO\)              16399
- 0x70000012 \(MIPS_UNREFEXTNO\)            14
- 0x70000013 \(MIPS_GOTSYM\)                0xf
+ 0x70000011 \(MIPS_SYMTABNO\)              [0-9]+
+ 0x70000012 \(MIPS_UNREFEXTNO\)            [0-9]+
+ 0x70000013 \(MIPS_GOTSYM\)                0x[0-9a-f]+
  0x00000000 \(NULL\)                       0x0
 
 Relocation section '\.rel\.dyn' at offset 0x[0-9a-f]+ contains 8203 entries:
Index: ld-mips-elf/multi-got-no-shared.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/multi-got-no-shared.d,v
retrieving revision 1.1
diff -u -r1.1 multi-got-no-shared.d
--- ld-mips-elf/multi-got-no-shared.d	5 Mar 2005 00:01:44 -0000	1.1
+++ ld-mips-elf/multi-got-no-shared.d	18 Aug 2005 00:46:08 -0000
@@ -8,11 +8,11 @@
 .*: +file format.*
 
 Disassembly of section \.text:
-004000b0 <[^>]*> 3c1c1000 	lui	gp,0x1000
-004000b4 <[^>]*> 279c7ff0 	addiu	gp,gp,32752
+004000b0 <[^>]*> 3c1c0046 	lui	gp,0x46
+004000b4 <[^>]*> 279c9ff0 	addiu	gp,gp,-24592
 004000b8 <[^>]*> afbc0008 	sw	gp,8\(sp\)
 #...
-00408d60 <[^>]*> 3c1c1002 	lui	gp,0x1002
-00408d64 <[^>]*> 279c9960 	addiu	gp,gp,-26272
+00408d60 <[^>]*> 3c1c0047 	lui	gp,0x47
+00408d64 <[^>]*> 279cb960 	addiu	gp,gp,-18080
 00408d68 <[^>]*> afbc0008 	sw	gp,8\(sp\)
 #pass
Index: ld-mips-elf/rel32-n32.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/rel32-n32.d,v
retrieving revision 1.6
diff -u -r1.6 rel32-n32.d
--- ld-mips-elf/rel32-n32.d	24 Mar 2005 22:47:52 -0000	1.6
+++ ld-mips-elf/rel32-n32.d	18 Aug 2005 00:46:08 -0000
@@ -4,12 +4,12 @@
 #readelf: -x 5 -r
 #ld: -shared -melf32btsmipn32
 
-Relocation section '.rel.dyn' at offset 0x304 contains 2 entries:
+Relocation section '.rel.dyn' at offset 0x2c0 contains 2 entries:
  Offset     Info    Type            Sym.Value  Sym. Name
 00000000  00000000 R_MIPS_NONE      
-00000330  00000003 R_MIPS_REL32     
+000002e0  00000003 R_MIPS_REL32     
 
 Hex dump of section '.text':
-  0x00000320 00000000 00000000 00000000 00000000 ................
-  0x00000330 00000330 00000000 00000000 00000000 ................
-  0x00000340 00000000 00000000 00000000 00000000 ................
+  0x000002d0 00000000 00000000 00000000 00000000 ................
+  0x000002e0 000002e0 00000000 00000000 00000000 ................
+  0x000002f0 00000000 00000000 00000000 00000000 ................
Index: ld-mips-elf/rel32-o32.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/rel32-o32.d,v
retrieving revision 1.5
diff -u -r1.5 rel32-o32.d
--- ld-mips-elf/rel32-o32.d	24 Mar 2005 22:47:52 -0000	1.5
+++ ld-mips-elf/rel32-o32.d	18 Aug 2005 00:46:08 -0000
@@ -4,12 +4,12 @@
 #readelf: -x 6 -r
 #ld: -shared -melf32btsmip
 
-Relocation section '.rel.dyn' at offset 0x31c contains 2 entries:
+Relocation section '.rel.dyn' at offset 0x2d8 contains 2 entries:
  Offset     Info    Type            Sym.Value  Sym. Name
 00000000  00000000 R_MIPS_NONE      
-00000340  00000003 R_MIPS_REL32     
+00000300  00000003 R_MIPS_REL32     
 
 Hex dump of section '.text':
-  0x00000330 00000000 00000000 00000000 00000000 ................
-  0x00000340 00000340 00000000 00000000 00000000 ................
-  0x00000350 00000000 00000000 00000000 00000000 ................
+  0x000002f0 00000000 00000000 00000000 00000000 ................
+  0x00000300 00000300 00000000 00000000 00000000 ................
+  0x00000310 00000000 00000000 00000000 00000000 ................
Index: ld-mips-elf/rel64.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/rel64.d,v
retrieving revision 1.5
diff -u -r1.5 rel64.d
--- ld-mips-elf/rel64.d	24 Mar 2005 22:47:52 -0000	1.5
+++ ld-mips-elf/rel64.d	18 Aug 2005 00:46:08 -0000
@@ -4,16 +4,16 @@
 #readelf: -x 6 -r
 #ld: -shared -melf64btsmip
 
-Relocation section '.rel.dyn' at offset 0x498 contains 2 entries:
+Relocation section '.rel.dyn' at offset 0x440 contains 2 entries:
   Offset          Info           Type           Sym. Value    Sym. Name
 000000000000  000000000000 R_MIPS_NONE      
                     Type2: R_MIPS_NONE      
                     Type3: R_MIPS_NONE      
-0000000004d0  000000001203 R_MIPS_REL32     
+000000000470  000000001203 R_MIPS_REL32     
                     Type2: R_MIPS_64        
                     Type3: R_MIPS_NONE      
 
 Hex dump of section '.text':
-  0x000004c0 00000000 00000000 00000000 00000000 ................
-  0x000004d0 00000000 000004d0 00000000 00000000 ................
-  0x000004e0 00000000 00000000 00000000 00000000 ................
+  0x00000460 00000000 00000000 00000000 00000000 ................
+  0x00000470 00000000 00000470 00000000 00000000 ................
+  0x00000480 00000000 00000000 00000000 00000000 ................

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix some FAILs in MIPS ld testsuite.
  2005-08-18  1:02 [PATCH] Fix some FAILs in MIPS ld testsuite David Daney
@ 2005-08-18  7:51 ` Thiemo Seufer
  0 siblings, 0 replies; 2+ messages in thread
From: Thiemo Seufer @ 2005-08-18  7:51 UTC (permalink / raw)
  To: David Daney; +Cc: binutils

David Daney wrote:
> Some recent changes to ld including, but not necessarily limited to:
> 
> http://sourceware.org/ml/binutils/2005-05/msg00712.html
> 
> Have caused some testsuite failures for the MIPS target.  For the five 
> tests covered by the attached patch the problem is in the testsuite.
> 
> There are other FAILures that I think are likley to be erroneously 
> caused by problems in the testsuite (mostly TLS related), but I am not 
> sure about those so I didn't fix them.
> 
> The attached patch fixes five FAILs.
> 
> 2005-08-17  David Daney  <ddaney@avtrex.com>
> 
> 	* ld-mips-elf/multi-got-1.d: Adjust for new ld behavior.
> 	* ld-mips-elf/multi-got-no-shared.d: Ditto.
> 	* ld-mips-elf/rel32-n32.d: Ditto.
> 	* ld-mips-elf/rel32-o32.d: Ditto.
> 	* ld-mips-elf/rel64.d: Ditto.
> 
> 
> OK to commit?

Ok, thanks for fixing this.


Thiemo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-08-18  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-18  1:02 [PATCH] Fix some FAILs in MIPS ld testsuite David Daney
2005-08-18  7:51 ` Thiemo Seufer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).