From: Arnold Metselaar <arnold.metselaar@planet.nl>
To: binutils@sources.redhat.com
Subject: [PATCH]: missing check in gas/app.c
Date: Wed, 14 Sep 2005 01:41:00 -0000 [thread overview]
Message-ID: <200509132241.10379.arnold.metselaar@planet.nl> (raw)
Hello
While working on as for target Z80, I noticed that a check for a
full buffer was missing after an optimised copy in
do_scrub_chars() in gas/app.c
A patch is below, it works with the assembler for Z80.
Side note: I sent the copyright assignment for binutils to FSF,
but I haven't heard from them yet.
Arnold Metselaar
*** src/gas/app.c 2005-05-05 11:12:43.000000000 +0200
--- src/gas/app.c.new 2005-09-13 22:24:44.000000000 +0200
***************
*** 1302,1307 ****
--- 1302,1310 ----
case 1: *to++ = *from++;
}
}
+ /* normally tested in PUT() */
+ if (to >= toend)
+ goto tofull;
ch = GET ();
}
}
next reply other threads:[~2005-09-13 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 1:41 Arnold Metselaar [this message]
2005-09-28 14:10 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509132241.10379.arnold.metselaar@planet.nl \
--to=arnold.metselaar@planet.nl \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).