From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8182 invoked by alias); 13 Sep 2005 20:41:13 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8081 invoked by uid 22791); 13 Sep 2005 20:41:09 -0000 Received: from smtp16.wxs.nl (HELO smtp16.wxs.nl) (195.121.6.39) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 13 Sep 2005 20:41:09 +0000 Received: from nilgiris (ip51cc2512.speed.planet.nl [81.204.37.18]) by smtp16.wxs.nl (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0IMR00AHIW4JL7@smtp16.wxs.nl> for binutils@sources.redhat.com; Tue, 13 Sep 2005 22:41:08 +0200 (CEST) Received: from arnold by nilgiris with local (Exim 3.36 #1 (Debian)) id 1EFHaa-0003Zu-00 for ; Tue, 13 Sep 2005 22:41:12 +0200 Date: Wed, 14 Sep 2005 01:41:00 -0000 From: Arnold Metselaar Subject: [PATCH]: missing check in gas/app.c To: binutils@sources.redhat.com Message-id: <200509132241.10379.arnold.metselaar@planet.nl> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline User-Agent: KMail/1.7.2 X-SW-Source: 2005-09/txt/msg00144.txt.bz2 Hello While working on as for target Z80, I noticed that a check for a full buffer was missing after an optimised copy in do_scrub_chars() in gas/app.c A patch is below, it works with the assembler for Z80. Side note: I sent the copyright assignment for binutils to FSF, but I haven't heard from them yet. Arnold Metselaar *** src/gas/app.c 2005-05-05 11:12:43.000000000 +0200 --- src/gas/app.c.new 2005-09-13 22:24:44.000000000 +0200 *************** *** 1302,1307 **** --- 1302,1310 ---- case 1: *to++ = *from++; } } + /* normally tested in PUT() */ + if (to >= toend) + goto tofull; ch = GET (); } }