From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com
Subject: Re: PATCH: Fix empty sections with alignment
Date: Tue, 27 Sep 2005 18:34:00 -0000 [thread overview]
Message-ID: <20050927150405.GA10788@lucon.org> (raw)
In-Reply-To: <20050927023315.GE29044@bubble.grove.modra.org>
On Tue, Sep 27, 2005 at 12:03:15PM +0930, Alan Modra wrote:
> On Mon, Sep 26, 2005 at 03:36:01PM -0700, H. J. Lu wrote:
> > This patch
> >
> > http://sourceware.org/ml/binutils/2005-09/msg00215.html
> >
> > breaks empty sections with alignment. The patch here works for me.
>
> It would be nice if you explained what was broken rather than leaving me
> to deduce that from your patch. In this case it's simple, but sometimes
> I'm not clever enough to immediately deduce what you think is broken.
>
> Before I OK this patch: Do you know whether any linker scripts depend
> on an address expression consisting of an ALIGN() being ignored like
> this? Besides those distributed with binutils, or prerelease linux
Yes, I do. That is how I noticed it. I am working for a sharable memory
project for clusters where the output sharable memory section should be
page aligned.
> kernels, I mean. The reason I ask is that I'm not really happy with the
> direction this patch is leading. We shouldn't be treating an ALIGN()
> specially. After all, ALIGN(x) as an address is supposed to be
> eqivalent to ((.+x-1)/x)*x, and people could reasonably expect that both
> expressions behave the same. Which they won't after your patch.
>
> Instead, I think we need some linker script construct that allows us to
> increase the alignment of an output section over that specified by its
> input sections, other than using ALIGN() as the address. Perhaps an
> ALIGN() after the semicolon. lang_enter_output_section_statement
> already supports an output section alignment.
I will look into it.
H.J.
next prev parent reply other threads:[~2005-09-27 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 1:19 H. J. Lu
2005-09-27 9:25 ` Alan Modra
2005-09-27 18:34 ` H. J. Lu [this message]
2005-09-27 21:21 ` H. J. Lu
2005-09-28 8:39 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050927150405.GA10788@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).