From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8979 invoked by alias); 28 Sep 2005 14:48:59 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8884 invoked by uid 22791); 28 Sep 2005 14:48:47 -0000 Received: from smtp113.sbc.mail.mud.yahoo.com (HELO smtp113.sbc.mail.mud.yahoo.com) (68.142.198.212) by sourceware.org (qpsmtpd/0.30-dev) with SMTP; Wed, 28 Sep 2005 14:48:47 +0000 Received: (qmail 32654 invoked from network); 28 Sep 2005 14:48:45 -0000 Received: from unknown (HELO lucon.org) (hjjean@sbcglobal.net@67.122.69.173 with login) by smtp113.sbc.mail.mud.yahoo.com with SMTP; 28 Sep 2005 14:48:45 -0000 Received: by lucon.org (Postfix, from userid 1000) id 82C9C63F98; Wed, 28 Sep 2005 07:48:44 -0700 (PDT) Date: Wed, 28 Sep 2005 17:16:00 -0000 From: "H. J. Lu" To: binutils@sourceware.org Subject: Re: patch ping Message-ID: <20050928144844.GA2693@lucon.org> References: <433921B1.76F0.0078.0@novell.com> <20050927162338.GA12037@lucon.org> <20050928115350.GQ29044@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050928115350.GQ29044@bubble.grove.modra.org> User-Agent: Mutt/1.4.1i X-SW-Source: 2005-09/txt/msg00329.txt.bz2 On Wed, Sep 28, 2005 at 09:23:50PM +0930, Alan Modra wrote: > > I started looking at this one, and got as far as the following patch: > * readelf.c (debug_apply_rela_addends): Relocate the whole > section. > > I'll leave this one for Nick to review, since I'm not sure of the > ramifications of this FIXME. > + /* FIXME: The relocation field size is relocation type dependent. */ > + unsigned int reloc_size = 4; It shouldn't matter unless the addend is >= 0xffffffff, which is quite rare. H.J.