From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1558 invoked by alias); 28 Sep 2005 15:27:42 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1545 invoked by uid 22791); 28 Sep 2005 15:27:38 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 28 Sep 2005 15:27:38 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EKdqK-0002cr-66 for binutils@sourceware.org; Wed, 28 Sep 2005 11:27:36 -0400 Date: Wed, 28 Sep 2005 19:27:00 -0000 From: Daniel Jacobowitz To: binutils@sourceware.org Subject: Re: patch ping Message-ID: <20050928152736.GA10075@nevyn.them.org> Mail-Followup-To: binutils@sourceware.org References: <433921B1.76F0.0078.0@novell.com> <20050927162338.GA12037@lucon.org> <20050928115350.GQ29044@bubble.grove.modra.org> <20050928144844.GA2693@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050928144844.GA2693@lucon.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00330.txt.bz2 On Wed, Sep 28, 2005 at 07:48:44AM -0700, H. J. Lu wrote: > On Wed, Sep 28, 2005 at 09:23:50PM +0930, Alan Modra wrote: > > > > I started looking at this one, and got as far as the following patch: > > * readelf.c (debug_apply_rela_addends): Relocate the whole > > section. > > > > I'll leave this one for Nick to review, since I'm not sure of the > > ramifications of this FIXME. > > + /* FIXME: The relocation field size is relocation type dependent. */ > > + unsigned int reloc_size = 4; > > It shouldn't matter unless the addend is >= 0xffffffff, which is quite > rare. Or negative and sign extended? e.g. mips64. -- Daniel Jacobowitz CodeSourcery, LLC