From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sourceware.org
Subject: Re: patch ping
Date: Wed, 28 Sep 2005 19:37:00 -0000 [thread overview]
Message-ID: <20050928154808.GA3605@lucon.org> (raw)
In-Reply-To: <20050928152736.GA10075@nevyn.them.org>
On Wed, Sep 28, 2005 at 11:27:36AM -0400, Daniel Jacobowitz wrote:
> On Wed, Sep 28, 2005 at 07:48:44AM -0700, H. J. Lu wrote:
> > On Wed, Sep 28, 2005 at 09:23:50PM +0930, Alan Modra wrote:
> > >
> > > I started looking at this one, and got as far as the following patch:
> > > * readelf.c (debug_apply_rela_addends): Relocate the whole
> > > section.
> > >
> > > I'll leave this one for Nick to review, since I'm not sure of the
> > > ramifications of this FIXME.
> > > + /* FIXME: The relocation field size is relocation type dependent. */
> > > + unsigned int reloc_size = 4;
> >
> > It shouldn't matter unless the addend is >= 0xffffffff, which is quite
> > rare.
>
> Or negative and sign extended? e.g. mips64.
>
MIPS is handled explicitly in debug_apply_rela_addends. But I have
no idea if it is done right or not. If we really want to make
debug_apply_rela_addends 100% correctly, it should get the relocation
size from the relocation type.
H.J.
next prev parent reply other threads:[~2005-09-28 15:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 9:51 Jan Beulich
2005-09-27 19:12 ` H. J. Lu
2005-09-28 13:27 ` Alan Modra
2005-09-28 17:16 ` H. J. Lu
2005-09-28 19:27 ` Daniel Jacobowitz
2005-09-28 19:37 ` H. J. Lu [this message]
2005-09-28 13:22 ` Alan Modra
-- strict thread matches above, loose matches on Subject: below --
2005-12-22 13:19 Jan-Benedict Glaw
2005-12-22 13:52 ` Matt Thomas
2005-12-22 18:15 ` Nick Clifton
2005-12-22 18:23 ` Jan-Benedict Glaw
2005-12-22 21:11 ` Hans-Peter Nilsson
2005-12-21 10:55 Jan Beulich
2005-12-13 8:00 Jan Beulich
2005-12-14 8:27 ` Andreas Jaeger
2005-09-27 21:53 Arnold Metselaar
2005-07-27 11:19 Patch ping Ben Elliston
2005-07-26 16:27 patch ping Jan Beulich
2005-07-26 23:45 ` Alan Modra
2005-06-27 10:35 Jan Beulich
2005-07-04 15:18 ` Nick Clifton
2003-10-02 15:23 Nathan Sidwell
2003-10-04 11:19 ` Nick Clifton
2003-02-19 23:15 Patch ping Phil Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050928154808.GA3605@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).