Re: Patch; let -subsystem option on pe targets actually affect entry symbol

[Christopher Faylor <cgf-use-the-mailinglist-please@cygwin.com>]

On Tue, Oct 04, 2005 at 08:30:04PM +1300, Danny Smith wrote:
>----- Original Message -----
>From: "Christopher Faylor"
>Sent: Thursday, 29 September 2005 02:27
>
>
>> On Tue, Sep 27, 2005 at 10:59:50PM +1200, Danny Smith wrote:
>> >However, I believe this may resurrect some old problems on cygwin, which
>> >does not provide a WinMainCRTStartup fumction. There used to be
>> >instructions in cygwin users guide on how to work-around this (ie, when
>> >setting windows subsystem either add an explict -e _mainCRTStartup or
>> >add a stub WinMainCRTStartup that just calls the console entry symbol),
>> >but those instruction have been removed.
>>
>> It sounds like, for cygwin, the simple solution for this, is to just include
>> a WinMainCRTStartup function which calls _manCRTStartup, right?
>
>Corrina's winsup commit to add a  WinMainCRTStartup alias to cygwin's crt0.c
>gets rid of the cygwin
> --subsystem windows warnings.
>
>Is the patch now okay to commit?
>
>        * emultempl/pe.em (gld_${EMULATION_NAME}_before_parse): Set
>        default entry symbol to ENTRY here.
>        * scripttempl/pe.sc: Not here.

Yes.

cgf