From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com, dcoutts@gentoo.org
Subject: Re: PATCH: binutils/2467: "ar q" / ranlib has large memory use (linear in archive size)
Date: Fri, 24 Mar 2006 07:27:00 -0000 [thread overview]
Message-ID: <20060324051735.GA2390@lucon.org> (raw)
In-Reply-To: <20060324011139.GB16236@bubble.grove.modra.org>
On Fri, Mar 24, 2006 at 11:41:39AM +1030, Alan Modra wrote:
> On Mon, Mar 20, 2006 at 06:23:03PM -0800, H. J. Lu wrote:
> > Will this patch break anything?
>
> I don't know the answer to that, but really, it's something that you as
> patch submitter should answer. You could gain a reasonable level of
I think it is safe. _bfd_generic_bfd_free_cached_info is called from
_bfd_compute_and_write_armap only. It has no problems with gcc build.
> confidence by allocating and scribbling on some memory after you've
> freed the objalloc. Test it with a coff an aout target too.
>
I added
abfd->sections = NULL;
abfd->section_last = NULL;
abfd->outsymbols = NULL;
abfd->tdata.any = NULL;
abfd->usrdata = NULL;
abfd->memory = NULL;
It doesn't cause any trouble. I checked i386-coff and i386-aout.
H.J.
next prev parent reply other threads:[~2006-03-24 5:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 6:03 H. J. Lu
2006-03-24 4:11 ` Alan Modra
2006-03-24 7:27 ` H. J. Lu [this message]
2006-04-07 1:08 ` H. J. Lu
2006-04-25 17:22 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324051735.GA2390@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
--cc=dcoutts@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).