public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Fix for PR 1860
@ 2006-03-31  2:32 Ben Elliston
  2006-03-31  2:37 ` DJ Delorie
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Elliston @ 2006-03-31  2:32 UTC (permalink / raw)
  To: binutils; +Cc: dave.anglin

After some experimentation, I determined that Texinfo 4.4 is now
required to build the binutils documentation.  The reason this is
probably not widely known is that many of us are now using a more
modern version of Texinfo such as 4.8.

Dave Anglin tripped over this on a system where he had Texinfo 4.2
installed.  After determining the minimum version requirement--a
version that supports @include{@value}--I have adjusted the top-level
configure script to check for it.

Tested with a number of configure && make all-binutils runs with
different makeinfo versions in my PATH.  Okay for mainline?

Ben

2006-03-31  Ben Elliston  <bje@au.ibm.com>

        PR binutils/1860
        * configure.in: Require makeinfo 4.4 or higher.
        * configure: Regenerate.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.301
diff -u -p -r1.301 configure.in
--- configure.in        14 Mar 2006 16:10:08 -0000      1.301
+++ configure.in        31 Mar 2006 02:15:26 -0000
@@ -2203,10 +2203,10 @@ case " $build_configdirs " in
   *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
   *)
 changequote(,)
-    # For an installed makeinfo, we require it to be from texinfo 4.2 or
+    # For an installed makeinfo, we require it to be from texinfo 4.4 or
     # higher, else we use the "missing" dummy.
     if ${MAKEINFO} --version \
-       | egrep 'texinfo[^0-9]*([1-3][0-9]|4\.[2-9]|[5-9])' >/dev/null 2>&1; then
+       | egrep 'texinfo[^0-9]*([1-3][0-9]|4\.[4-9]|[5-9])' >/dev/null 2>&1; then
       :
     else
       MAKEINFO="$MISSING makeinfo"
Index: configure
===================================================================
RCS file: /cvs/src/src/configure,v
retrieving revision 1.214
diff -u -p -r1.214 configure
--- configure   14 Mar 2006 16:10:08 -0000      1.214
+++ configure   31 Mar 2006 02:15:41 -0000
@@ -3628,10 +3628,10 @@ case " $build_configdirs " in
   *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;;
   *)
 
-    # For an installed makeinfo, we require it to be from texinfo 4.2 or
+    # For an installed makeinfo, we require it to be from texinfo 4.4 or
     # higher, else we use the "missing" dummy.
     if ${MAKEINFO} --version \
-       | egrep 'texinfo[^0-9]*([1-3][0-9]|4\.[2-9]|[5-9])' >/dev/null 2>&1; then
+       | egrep 'texinfo[^0-9]*([1-3][0-9]|4\.[4-9]|[5-9])' >/dev/null 2>&1; then
       :
     else
       MAKEINFO="$MISSING makeinfo"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix for PR 1860
  2006-03-31  2:32 Fix for PR 1860 Ben Elliston
@ 2006-03-31  2:37 ` DJ Delorie
  2006-03-31  3:08   ` Ben Elliston
  0 siblings, 1 reply; 3+ messages in thread
From: DJ Delorie @ 2006-03-31  2:37 UTC (permalink / raw)
  To: bje; +Cc: binutils, dave.anglin


> 2006-03-31  Ben Elliston  <bje@au.ibm.com>
> 
>         PR binutils/1860
>         * configure.in: Require makeinfo 4.4 or higher.
>         * configure: Regenerate.

Technically acceptable, but please consider that you're changing the
requirements for more than just binutils.  Check with gcc, gdb,
newlib, and cygwin; if nobody objects, go ahead and commit it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix for PR 1860
  2006-03-31  2:37 ` DJ Delorie
@ 2006-03-31  3:08   ` Ben Elliston
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Elliston @ 2006-03-31  3:08 UTC (permalink / raw)
  To: DJ Delorie; +Cc: binutils, dave.anglin

> Technically acceptable, but please consider that you're changing the
> requirements for more than just binutils.  Check with gcc, gdb,
> newlib, and cygwin; if nobody objects, go ahead and commit it.

Whoops -- Alan already approved it and I committed it.  I should add
the following extra details that I wrote up in the bug report:

  Texinfo 4.2 was released on 1 April 2002.
  Texinfo 4.3 was released on 14 November 2002.
  Texinfo 4.4 was released in 31 January 2003.

  I think that raising the minimum requirement on Texinfo to version
  4.4 is quite safe.

Nevertheless, I will follow-up with the other projects.

Ben

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-03-31  2:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-31  2:32 Fix for PR 1860 Ben Elliston
2006-03-31  2:37 ` DJ Delorie
2006-03-31  3:08   ` Ben Elliston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).