From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org, Sergey Ilyevsky <silyevsk@gmail.com>
Subject: Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
Date: Fri, 31 Mar 2006 11:44:00 -0000 [thread overview]
Message-ID: <20060331112110.GJ22210@lug-owl.de> (raw)
In-Reply-To: <7bf3ae9d0603310312y3cbdaebcv85d04897415d046d@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2286 bytes --]
Hi Nick!
On Fri, 2006-03-31 13:12:21 +0200, Sergey Ilyevsky <silyevsk@gmail.com> wrote:
> 2006/3/31, Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> > I was asked to have a look at
> > http://sourceware.org/bugzilla/show_bug.cgi?id=2494 . The bug
> > reporter complains about SEC (set carry) being used by his assembler,
> > but the final output generates CLC (clear carry.) This preliminary
> > patch should fix it, but it's untested (and I'm not actually a PDP11
> > maintainer.) The new opcode was taken out of my "VAX Architecture
> > Reference Manual", EY-3459E-DP, 0-932376-86-X, p. 326 (PDP-11
> > Compatibility Mode, Condition Code Operators.)
> >
> > 2006-03-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
> >
> > opcodes/
> > * pdp11-opc.c (pdp11_opcodes): Correct binary representation of SEC.
> >
> > diff -Nurp src-binutils-fresh/opcodes/pdp11-opc.c src-binutils-hacked/opcodes/pdp11-opc.c
> > --- src-binutils-fresh/opcodes/pdp11-opc.c 2005-05-07 09:34:30.000000000 +0200
> > +++ src-binutils-hacked/opcodes/pdp11-opc.c 2006-03-31 10:13:39.000000000 +0200
> > @@ -50,7 +50,7 @@ const struct pdp11_opcode pdp11_opcodes[
> > { "cl_e", 0x00ae, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "ccc", 0x00af, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "se_0", 0x00b0, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "sev", 0x00b2, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "se_3", 0x00b3, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "sez", 0x00b4, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> Actually I don't have pdp11 as well ;-) .
> I'm using the assembler on i686.
> With the patch it works fine.
May I check this in under the obvious rule?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-03-31 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 11:12 Jan-Benedict Glaw
2006-03-31 11:21 ` Sergey Ilyevsky
2006-03-31 11:44 ` Jan-Benedict Glaw [this message]
2006-03-31 12:00 ` Alan Modra
2006-03-31 14:56 ` Jan-Benedict Glaw
2006-03-31 15:03 ` Paul Koning
2006-03-31 15:57 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331112110.GJ22210@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=silyevsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).