* [PR 2494] PDP-11: Wrong opcode for SEC/CLC
@ 2006-03-31 11:12 Jan-Benedict Glaw
2006-03-31 11:21 ` Sergey Ilyevsky
0 siblings, 1 reply; 7+ messages in thread
From: Jan-Benedict Glaw @ 2006-03-31 11:12 UTC (permalink / raw)
To: silyevsk; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]
Hi Sergey, hi list readers!
I was asked to have a look at
http://sourceware.org/bugzilla/show_bug.cgi?id=2494 . The bug
reporter complains about SEC (set carry) being used by his assembler,
but the final output generates CLC (clear carry.) This preliminary
patch should fix it, but it's untested (and I'm not actually a PDP11
maintainer.) The new opcode was taken out of my "VAX Architecture
Reference Manual", EY-3459E-DP, 0-932376-86-X, p. 326 (PDP-11
Compatibility Mode, Condition Code Operators.)
I actually do not have a PDP-11 (unfortunately:-) and AFAIK all my
VAXen are too new and don't come along with hardware PDP-11
compatibility, nor do I have any PDP-11 software to test this with,
so Sergey, could you please give it a run?
MfG, JBG
2006-03-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
opcodes/
* pdp11-opc.c (pdp11_opcodes): Correct binary representation of SEC.
diff -Nurp src-binutils-fresh/opcodes/pdp11-opc.c src-binutils-hacked/opcodes/pdp11-opc.c
--- src-binutils-fresh/opcodes/pdp11-opc.c 2005-05-07 09:34:30.000000000 +0200
+++ src-binutils-hacked/opcodes/pdp11-opc.c 2006-03-31 10:13:39.000000000 +0200
@@ -50,7 +50,7 @@ const struct pdp11_opcode pdp11_opcodes[
{ "cl_e", 0x00ae, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
{ "ccc", 0x00af, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
{ "se_0", 0x00b0, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
- { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
+ { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
{ "sev", 0x00b2, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
{ "se_3", 0x00b3, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
{ "sez", 0x00b4, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 11:12 [PR 2494] PDP-11: Wrong opcode for SEC/CLC Jan-Benedict Glaw
@ 2006-03-31 11:21 ` Sergey Ilyevsky
2006-03-31 11:44 ` Jan-Benedict Glaw
0 siblings, 1 reply; 7+ messages in thread
From: Sergey Ilyevsky @ 2006-03-31 11:21 UTC (permalink / raw)
To: binutils
Hi All,
Actually I don't have pdp11 as well ;-) .
I'm using the assembler on i686.
With the patch it works fine.
Thanks!
2006/3/31, Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> Hi Sergey, hi list readers!
>
> I was asked to have a look at
> http://sourceware.org/bugzilla/show_bug.cgi?id=2494 . The bug
> reporter complains about SEC (set carry) being used by his assembler,
> but the final output generates CLC (clear carry.) This preliminary
> patch should fix it, but it's untested (and I'm not actually a PDP11
> maintainer.) The new opcode was taken out of my "VAX Architecture
> Reference Manual", EY-3459E-DP, 0-932376-86-X, p. 326 (PDP-11
> Compatibility Mode, Condition Code Operators.)
>
> I actually do not have a PDP-11 (unfortunately:-) and AFAIK all my
> VAXen are too new and don't come along with hardware PDP-11
> compatibility, nor do I have any PDP-11 software to test this with,
> so Sergey, could you please give it a run?
>
> MfG, JBG
>
> 2006-03-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> opcodes/
> * pdp11-opc.c (pdp11_opcodes): Correct binary representation of SEC.
>
> diff -Nurp src-binutils-fresh/opcodes/pdp11-opc.c src-binutils-hacked/opcodes/pdp11-opc.c
> --- src-binutils-fresh/opcodes/pdp11-opc.c 2005-05-07 09:34:30.000000000 +0200
> +++ src-binutils-hacked/opcodes/pdp11-opc.c 2006-03-31 10:13:39.000000000 +0200
> @@ -50,7 +50,7 @@ const struct pdp11_opcode pdp11_opcodes[
> { "cl_e", 0x00ae, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> { "ccc", 0x00af, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> { "se_0", 0x00b0, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> { "sev", 0x00b2, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> { "se_3", 0x00b3, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> { "sez", 0x00b4, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
>
> --
> Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
> "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
> für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
> ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFELOnxHb1edYOZ4bsRAoZlAJ9fH3nEGqSlNPFHbvmKJnz5ipO2EgCfcqKG
> Yjwlt/IFEXpiv2gtOYZ6sgo=
> =j6z8
> -----END PGP SIGNATURE-----
>
>
>
--
Regards,
Sergey Ilyevsky.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 11:21 ` Sergey Ilyevsky
@ 2006-03-31 11:44 ` Jan-Benedict Glaw
2006-03-31 12:00 ` Alan Modra
0 siblings, 1 reply; 7+ messages in thread
From: Jan-Benedict Glaw @ 2006-03-31 11:44 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils, Sergey Ilyevsky
[-- Attachment #1: Type: text/plain, Size: 2286 bytes --]
Hi Nick!
On Fri, 2006-03-31 13:12:21 +0200, Sergey Ilyevsky <silyevsk@gmail.com> wrote:
> 2006/3/31, Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> > I was asked to have a look at
> > http://sourceware.org/bugzilla/show_bug.cgi?id=2494 . The bug
> > reporter complains about SEC (set carry) being used by his assembler,
> > but the final output generates CLC (clear carry.) This preliminary
> > patch should fix it, but it's untested (and I'm not actually a PDP11
> > maintainer.) The new opcode was taken out of my "VAX Architecture
> > Reference Manual", EY-3459E-DP, 0-932376-86-X, p. 326 (PDP-11
> > Compatibility Mode, Condition Code Operators.)
> >
> > 2006-03-31 Jan-Benedict Glaw <jbglaw@lug-owl.de>
> >
> > opcodes/
> > * pdp11-opc.c (pdp11_opcodes): Correct binary representation of SEC.
> >
> > diff -Nurp src-binutils-fresh/opcodes/pdp11-opc.c src-binutils-hacked/opcodes/pdp11-opc.c
> > --- src-binutils-fresh/opcodes/pdp11-opc.c 2005-05-07 09:34:30.000000000 +0200
> > +++ src-binutils-hacked/opcodes/pdp11-opc.c 2006-03-31 10:13:39.000000000 +0200
> > @@ -50,7 +50,7 @@ const struct pdp11_opcode pdp11_opcodes[
> > { "cl_e", 0x00ae, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "ccc", 0x00af, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "se_0", 0x00b0, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "sev", 0x00b2, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "se_3", 0x00b3, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > { "sez", 0x00b4, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> Actually I don't have pdp11 as well ;-) .
> I'm using the assembler on i686.
> With the patch it works fine.
May I check this in under the obvious rule?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 11:44 ` Jan-Benedict Glaw
@ 2006-03-31 12:00 ` Alan Modra
2006-03-31 14:56 ` Jan-Benedict Glaw
0 siblings, 1 reply; 7+ messages in thread
From: Alan Modra @ 2006-03-31 12:00 UTC (permalink / raw)
To: Jan-Benedict Glaw; +Cc: Nick Clifton, binutils, Sergey Ilyevsky
On Fri, Mar 31, 2006 at 01:21:11PM +0200, Jan-Benedict Glaw wrote:
> > > - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > > + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
>
> May I check this in under the obvious rule?
Yes, that would have been OK, but someone else posted a patch before
this one, which I've committed.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 12:00 ` Alan Modra
@ 2006-03-31 14:56 ` Jan-Benedict Glaw
2006-03-31 15:03 ` Paul Koning
0 siblings, 1 reply; 7+ messages in thread
From: Jan-Benedict Glaw @ 2006-03-31 14:56 UTC (permalink / raw)
To: Nick Clifton, binutils, Sergey Ilyevsky
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Fri, 2006-03-31 21:16:03 +0930, Alan Modra <amodra@bigpond.net.au> wrote:
> On Fri, Mar 31, 2006 at 01:21:11PM +0200, Jan-Benedict Glaw wrote:
> > > > - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> > > > + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC },
> >
> > May I check this in under the obvious rule?
>
> Yes, that would have been OK, but someone else posted a patch before
> this one, which I've committed.
*gnarf* So we had a nice overlap and no hint in the PR. However, the
bug is fixed, so everything is okay again :-)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 14:56 ` Jan-Benedict Glaw
@ 2006-03-31 15:03 ` Paul Koning
2006-03-31 15:57 ` Jan-Benedict Glaw
0 siblings, 1 reply; 7+ messages in thread
From: Paul Koning @ 2006-03-31 15:03 UTC (permalink / raw)
To: jbglaw; +Cc: nickc, binutils, silyevsk
>>>>> "Jan-Benedict" == Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:
Jan-Benedict> On Fri, 2006-03-31 21:16:03 +0930, Alan Modra
Jan-Benedict> <amodra@bigpond.net.au> wrote:
>> On Fri, Mar 31, 2006 at 01:21:11PM +0200, Jan-Benedict Glaw wrote:
>> > > > - { "sec", 0x00a1, 0xffff, PDP11_OPCODE_NO_OPS, PDP11_BASIC
>> }, > > > + { "sec", 0x00b1, 0xffff, PDP11_OPCODE_NO_OPS,
>> PDP11_BASIC },
>> >
>> > May I check this in under the obvious rule?
>>
>> Yes, that would have been OK, but someone else posted a patch
>> before this one, which I've committed.
Jan-Benedict> *gnarf* So we had a nice overlap and no hint in the
Jan-Benedict> PR. However, the bug is fixed, so everything is okay
Jan-Benedict> again :-)
Sorry... I wasn't sure about all the proper procedures. I'll be
better prepared next time.
paul
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC
2006-03-31 15:03 ` Paul Koning
@ 2006-03-31 15:57 ` Jan-Benedict Glaw
0 siblings, 0 replies; 7+ messages in thread
From: Jan-Benedict Glaw @ 2006-03-31 15:57 UTC (permalink / raw)
To: Paul Koning; +Cc: nickc, binutils, silyevsk
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On Fri, 2006-03-31 09:55:58 -0500, Paul Koning <pkoning@equallogic.com> wrote:
> >>>>> "Jan-Benedict" == Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:
> Jan-Benedict> *gnarf* So we had a nice overlap and no hint in the
> Jan-Benedict> PR. However, the bug is fixed, so everything is okay
> Jan-Benedict> again :-)
>
> Sorry... I wasn't sure about all the proper procedures. I'll be
> better prepared next time.
No problem here (on my side, at least:-) -- nothing to be sorry about.
There were just too many parties involved with no synchronization in
between.
It didn't really produce a lot of doubled work, I've got some nice
scripts that help me, so no real "work" except having a look at my
books.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-03-31 15:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-31 11:12 [PR 2494] PDP-11: Wrong opcode for SEC/CLC Jan-Benedict Glaw
2006-03-31 11:21 ` Sergey Ilyevsky
2006-03-31 11:44 ` Jan-Benedict Glaw
2006-03-31 12:00 ` Alan Modra
2006-03-31 14:56 ` Jan-Benedict Glaw
2006-03-31 15:03 ` Paul Koning
2006-03-31 15:57 ` Jan-Benedict Glaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).