From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com
Subject: PATCH: Fix default_binutils_run to check exit status
Date: Thu, 06 Apr 2006 21:50:00 -0000 [thread overview]
Message-ID: <20060406211155.GA13554@lucon.org> (raw)
default_binutils_run doesn't check exit status. If a program
segfaults and doesn't generate any output, default_binutils_run
think it is successful. This patch checks exit status.
H.J.
----
2006-04-06 H.J. Lu <hongjiu.lu@intel.com>
* lib/utils-lib.exp (default_binutils_run): Check exit status.
--- binutils/testsuite/lib/utils-lib.exp.status 2005-05-08 07:17:41.000000000 -0700
+++ binutils/testsuite/lib/utils-lib.exp 2006-04-06 12:59:45.000000000 -0700
@@ -73,6 +73,12 @@ proc default_binutils_run { prog progarg
if {![string match "" $exec_output]} then {
send_log "$exec_output\n"
verbose "$exec_output"
+ } else {
+ if { [lindex $state 0] != 0 } {
+ set exec_output "$prog exited with status [lindex $state 0]"
+ send_log "$exec_output\n"
+ verbose "$exec_output"
+ }
}
return $exec_output
}
next reply other threads:[~2006-04-06 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 21:50 H. J. Lu [this message]
2006-04-10 16:02 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406211155.GA13554@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).