public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: binutils@sourceware.org
Subject: Be more liberal in ignoring ARM mapping symbols
Date: Tue, 11 Apr 2006 18:46:00 -0000	[thread overview]
Message-ID: <20060411163706.GA30741@nevyn.them.org> (raw)

I noticed today that the ARM compiler also generates $b mapping symbols.
Rather than continuing to play catch-up, this makes $<character> and
$<character>.<string> be generally ignored.  Is this OK?

-- 
Daniel Jacobowitz
CodeSourcery

2006-04-11  Daniel Jacobowitz  <dan@codesourcery.com>

	* bfd/cpu-arm.c (bfd_is_arm_mapping_symbol_name): Accept more
	mapping symbols.

Index: bfd/cpu-arm.c
===================================================================
RCS file: /cvs/src/src/bfd/cpu-arm.c,v
retrieving revision 1.19.12.1
diff -u -p -r1.19.12.1 cpu-arm.c
--- bfd/cpu-arm.c	11 Apr 2006 15:54:53 -0000	1.19.12.1
+++ bfd/cpu-arm.c	11 Apr 2006 16:25:25 -0000
@@ -405,11 +405,11 @@ bfd_boolean
 bfd_is_arm_mapping_symbol_name (const char * name)
 {
   /* The ARM compiler outputs several obsolete forms.  Recognize them
-     in addition to the standard $a, $t and $d.  */
+     in addition to the standard $a, $t and $d.  We are somewhat loose
+     in what we accept here, since the full set is not documented.  */
   return (name != NULL)
     && (name[0] == '$')
-    && ((name[1] == 'a') || (name[1] == 't') || (name[1] == 'd')
-	|| (name[1] == 'm') || (name[1] == 'f') || (name[1] == 'p'))
+    && (name[1] >= 'a' && name[1] <= 'z')
     && (name[2] == 0 || name[2] == '.');
 }
 

             reply	other threads:[~2006-04-11 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 18:46 Daniel Jacobowitz [this message]
2006-04-25 17:33 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060411163706.GA30741@nevyn.them.org \
    --to=drow@false.org \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).