From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4181 invoked by alias); 11 Apr 2006 16:37:11 -0000 Received: (qmail 4173 invoked by uid 22791); 11 Apr 2006 16:37:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 11 Apr 2006 16:37:09 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FTLrW-00080S-R0 for binutils@sourceware.org; Tue, 11 Apr 2006 12:37:06 -0400 Date: Tue, 11 Apr 2006 18:46:00 -0000 From: Daniel Jacobowitz To: binutils@sourceware.org Subject: Be more liberal in ignoring ARM mapping symbols Message-ID: <20060411163706.GA30741@nevyn.them.org> Mail-Followup-To: binutils@sourceware.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.8i Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00157.txt.bz2 I noticed today that the ARM compiler also generates $b mapping symbols. Rather than continuing to play catch-up, this makes $ and $. be generally ignored. Is this OK? -- Daniel Jacobowitz CodeSourcery 2006-04-11 Daniel Jacobowitz * bfd/cpu-arm.c (bfd_is_arm_mapping_symbol_name): Accept more mapping symbols. Index: bfd/cpu-arm.c =================================================================== RCS file: /cvs/src/src/bfd/cpu-arm.c,v retrieving revision 1.19.12.1 diff -u -p -r1.19.12.1 cpu-arm.c --- bfd/cpu-arm.c 11 Apr 2006 15:54:53 -0000 1.19.12.1 +++ bfd/cpu-arm.c 11 Apr 2006 16:25:25 -0000 @@ -405,11 +405,11 @@ bfd_boolean bfd_is_arm_mapping_symbol_name (const char * name) { /* The ARM compiler outputs several obsolete forms. Recognize them - in addition to the standard $a, $t and $d. */ + in addition to the standard $a, $t and $d. We are somewhat loose + in what we accept here, since the full set is not documented. */ return (name != NULL) && (name[0] == '$') - && ((name[1] == 'a') || (name[1] == 't') || (name[1] == 'd') - || (name[1] == 'm') || (name[1] == 'f') || (name[1] == 'p')) + && (name[1] >= 'a' && name[1] <= 'z') && (name[2] == 0 || name[2] == '.'); }