public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H. J. Lu" <hjl@lucon.org>
To: Bob Wilson <bwilson@tensilica.com>
Cc: binutils@sources.redhat.com
Subject: Re: [Xtensa] add LD workaround for inconsistent linkonce sections
Date: Fri, 14 Apr 2006 22:50:00 -0000	[thread overview]
Message-ID: <20060414220025.GA1391@lucon.org> (raw)
In-Reply-To: <44401755.3000001@tensilica.com>

On Fri, Apr 14, 2006 at 02:42:45PM -0700, Wilson; Bob, Tensillca wrote:
> This is patch is a workaround for a problem with .gnu.linkonce sections 
> that is better solved by using COMDAT groups.  Xtensa "property tables" 
> describing linkonce sections must be kept together with those sections in 
> a link.  If a linkonce section is taken from one input file, and the 
> corresponding property table is taken from a different input file, bad 
> things happen.  This doesn't normally happen, but it can occur when a 
> particular property table is missing from one input file.  (I think an 
> alternate solution would be to require property tables to exist even when 
> they are empty.)  When property tables are kept in COMDAT groups with the 
> sections they describe, the whole problem will be nicely avoided.  In the 
> meantime, this patch iterates over all the sections included in the link 
> and throws out any property tables that are inconsistent, i.e., that refer 
> to sections from different input files.
> 

ia64 has the same issue with unwind sections. We just fake a comdat
group for unwind sections.


H.J.

  reply	other threads:[~2006-04-14 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-14 22:00 Bob Wilson
2006-04-14 22:50 ` H. J. Lu [this message]
2006-04-14 22:54   ` Bob Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060414220025.GA1391@lucon.org \
    --to=hjl@lucon.org \
    --cc=binutils@sources.redhat.com \
    --cc=bwilson@tensilica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).