From: Bernd Jendrissek <berndj@prism.co.za>
To: binutils@sourceware.org
Subject: Re: configure help message formatting
Date: Wed, 19 Apr 2006 12:07:00 -0000 [thread overview]
Message-ID: <20060419074003.GB11759@prism.co.za> (raw)
In-Reply-To: <20060419015433.GC19444@bubble.grove.modra.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NotDashEscaped: You need GnuPG to verify this message
On Wed, Apr 19, 2006 at 11:24:33AM +0930, Alan Modra wrote:
> configure --help formatting still isn't anywhere near perfect, but this
> fixes some indentation problems in files controlled by binutils.
>
> bfd/
> * warning.m4 (--enable-werror, -build-warnings): Format help messages.
> * configure: Regenerate.
> binutils/
> * configure: Regenerate.
> gas/
> * configure.in (--enable-targets): Indent help message.
> * configure: Regenerate.
> gprof/
> * configure: Regenerate.
> ld/
> * configure: Regenerate.
> opcodes/
> * configure: Regenerate.
Aren't these ./configuren generated by autoconf 2.5x? Couldn't you have
just used AS_HELP_STRING([--enable-werror], [treat compile ...]) and let
it get the indentation right, or what am I forgetting?
[Warning: hand-hacked patch follows, apply with care on top of yours]
diff -u -p -r1.2 warning.m4
--- bfd/warning.m4 7 Nov 2005 22:14:12 -0000 1.2
+++ bfd/warning.m4 18 Apr 2006 14:25:44 -0000
@@ -4,7 +4,7 @@ AC_DEFUN([AM_BINUTILS_WARNINGS],[
GCC_WARN_CFLAGS="-W -Wall -Wstrict-prototypes -Wmissing-prototypes"
AC_ARG_ENABLE(werror,
- [ --enable-werror treat compile warnings as errors],
+ AS_HELP_STRING([--enable-werror], [treat compile warnings as errors]),
[case "${enableval}" in
yes | y) ERROR_ON_WARNING="yes" ;;
no | n) ERROR_ON_WARNING="no" ;;
@@ -27,7 +27,8 @@ if test "${GCC}" = yes ; then
fi
AC_ARG_ENABLE(build-warnings,
-[ --enable-build-warnings enable build-time compiler warnings],
+AS_HELP_STRING([--enable-build-warnings],
+ [enable build-time compiler warnings]),
[case "${enableval}" in
yes) WARN_CFLAGS="${GCC_WARN_CFLAGS}";;
no) if test "${GCC}" = yes ; then
diff -u -p -r1.188 configure.in
--- gas/configure.in 6 Apr 2006 21:49:33 -0000 1.188
+++ gas/configure.in 18 Apr 2006 14:26:04 -0000
@@ -23,7 +23,8 @@ AM_INIT_AUTOMAKE(gas, ${BFD_VERSION})
AM_PROG_LIBTOOL
AC_ARG_ENABLE(targets,
-[ --enable-targets alternative target configurations besides the primary],
+AS_HELP_STRING([--enable-targets],
+ [alternative target configurations besides the primary]),
[case "${enableval}" in
yes | "") AC_ERROR(enable-targets option must specify target names or 'all')
;;
--
A PC without Windows is like ice cream without ketchup.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Please fetch my new key 804177F8 from hkp://wwwkeys.eu.pgp.net/
iD8DBQFERelFwyMv24BBd/gRAqEyAJ9gAUPN3/8gFQTGokIRJ2OiVET9gQCggLk1
4jRBPiboW3XAILTuq7AW6yo=
=d6W4
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2006-04-19 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 2:01 Alan Modra
2006-04-19 12:07 ` Bernd Jendrissek [this message]
2006-04-19 14:13 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060419074003.GB11759@prism.co.za \
--to=berndj@prism.co.za \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).