From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8891 invoked by alias); 21 Apr 2006 22:26:58 -0000 Received: (qmail 8883 invoked by uid 22791); 21 Apr 2006 22:26:57 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Apr 2006 22:26:55 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 37EC21EBF7; Sat, 22 Apr 2006 00:26:52 +0200 (CEST) From: Andi Kleen To: discuss@x86-64.org Subject: Re: [discuss] RE: [PATCH] [1/2] x86_64: Pass -32 to the assembler when compiling the 32bit vsyscall pages Date: Sun, 23 Apr 2006 20:24:00 -0000 User-Agent: KMail/1.9.1 Cc: "H. J. Lu" , "Baker, Brian (ISS - Houston)" , torvalds@osdl.org, akpm@osdl.org, "Altobelli, David" , binutils@sources.redhat.com References: <6095103C4F0ACD4FAE3522E0F27ADF42022CEE33@cceexc13.americas.cpqcorp.net> <20060421145001.GA13830@lucon.org> In-Reply-To: <20060421145001.GA13830@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604220025.53501.ak@suse.de> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00313.txt.bz2 > > Index: linux/arch/x86_64/ia32/Makefile > > =================================================================== > > --- linux.orig/arch/x86_64/ia32/Makefile > > +++ linux/arch/x86_64/ia32/Makefile > > @@ -27,5 +27,5 @@ $(obj)/vsyscall-sysenter.so $(obj)/vsysc > > $(obj)/vsyscall-%.so: $(src)/vsyscall.lds $(obj)/vsyscall-%.o FORCE > > $(call if_changed,syscall) > > > > -AFLAGS_vsyscall-sysenter.o = -m32 > > -AFLAGS_vsyscall-syscall.o = -m32 > > +AFLAGS_vsyscall-sysenter.o = -m32 -Wa,-32 > > +AFLAGS_vsyscall-syscall.o = -m32 -Wa,-32 > > I can't reproduce it What did you try exactly? You have to recompile the file and either run the pthreads cancellation test case with the right glibc version, or examine the unwind tables in the .so by hand. Or just check if the warning appears or not. > with binutils 2.16.91.0.5. Unless you have a bad > gcc driver, -m32 will pass --32 to assembler, which is the same as -32. It definitely fixed the problem here and the warning went away. gcc used was 4.1 But you're right it could have been the gcc - in the case where it worked I was using gcc 4.0. -Andi