From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16504 invoked by alias); 26 Apr 2006 01:26:51 -0000 Received: (qmail 16495 invoked by uid 22791); 26 Apr 2006 01:26:50 -0000 X-Spam-Check-By: sourceware.org Received: from smtp104.sbc.mail.mud.yahoo.com (HELO smtp104.sbc.mail.mud.yahoo.com) (68.142.198.203) by sourceware.org (qpsmtpd/0.31) with SMTP; Wed, 26 Apr 2006 01:26:48 +0000 Received: (qmail 50458 invoked from network); 26 Apr 2006 01:26:46 -0000 Received: from unknown (HELO lucon.org) (hjjean@sbcglobal.net@75.0.171.244 with login) by smtp104.sbc.mail.mud.yahoo.com with SMTP; 26 Apr 2006 01:26:46 -0000 Received: by lucon.org (Postfix, from userid 1000) id 9B33664034; Tue, 25 Apr 2006 18:26:44 -0700 (PDT) Date: Wed, 26 Apr 2006 09:24:00 -0000 From: "H. J. Lu" To: binutils@sources.redhat.com Subject: Re: PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got Message-ID: <20060426012644.GA1442@lucon.org> References: <20060425222618.GA32676@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060425222618.GA32676@lucon.org> User-Agent: Mutt/1.4.2.1i Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00367.txt.bz2 On Tue, Apr 25, 2006 at 03:26:18PM -0700, H. J. Lu wrote: > Gcc may generate a section with SHF_ALPHA_GPREL. Assembler shouldn't > complain. This patch does it. > > I am not really sure if SHF_ALPHA_GPREL is really needed. This is the updated patch to properly allow it. H.J. --- 2006-04-25 H.J. Lu PR gas/2598 * config/obj-elf.c (obj_elf_change_section): Allow user specified SHF_ALPHA_GPREL. --- gas/config/obj-elf.c.alpha 2005-09-26 12:13:55.000000000 -0700 +++ gas/config/obj-elf.c 2006-04-25 18:16:36.000000000 -0700 @@ -632,6 +632,11 @@ obj_elf_change_section (const char *name else if (attr == SHF_EXECINSTR && strcmp (name, ".note.GNU-stack") == 0) override = TRUE; +#ifdef TC_ALPHA + /* A section on Alpha may have SHF_ALPHA_GPREL. */ + else if ((attr & ~ssect->attr) == SHF_ALPHA_GPREL) + override = TRUE; +#endif else { if (group_name == NULL)