From: Alan Modra <amodra@bigpond.net.au>
To: Kaz Kojima <kkojima@rr.iij4u.or.jp>
Cc: binutils@sources.redhat.com
Subject: Re: [patch RFC] Fix PR binutils/2584
Date: Thu, 27 Apr 2006 03:27:00 -0000 [thread overview]
Message-ID: <20060427022012.GB17615@bubble.grove.modra.org> (raw)
In-Reply-To: <20060427.080623.74752937.kkojima@rr.iij4u.or.jp>
On Thu, Apr 27, 2006 at 08:06:23AM +0900, Kaz Kojima wrote:
> PR 2584
> * tekhex.c (first_phase): Change return type to bfd_boolean
> and return false if the unexpected character is found.
> (pass_over): Change return type to bfd_boolean and the type of
> the second argument to bfd_boolean (*) (bfd *, int, char *).
> Return false if FUNC returns false.
> (tekhex_object_p): Return NULL if pass_over fails.
Thanks, but can I ask that you do this differently? Add an
unsigned int * param to getsym to return the length, and move the hex
check into getsym. Return false from getsym on bad hex chars.
Similarly add a bfd_vma * param to getvalue to return the value and
return status via the function return. Also replace "abort ()" in
first_phase with "return FALSE" while you're at it. Patch preapproved.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2006-04-27 2:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 2:20 Kaz Kojima
2006-04-27 3:27 ` Alan Modra [this message]
2006-04-27 6:13 ` Kaz Kojima
2006-04-27 18:17 ` Alan Modra
2006-04-27 18:25 ` Kaz Kojima
2006-05-03 0:52 ` Kaz Kojima
2006-05-03 3:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060427022012.GB17615@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=kkojima@rr.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).