From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7182 invoked by alias); 1 May 2006 06:03:07 -0000 Received: (qmail 7174 invoked by uid 22791); 1 May 2006 06:03:07 -0000 X-Spam-Check-By: sourceware.org Received: from CPE-144-136-172-108.sa.bigpond.net.au (HELO grove.modra.org) (144.136.172.108) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 May 2006 06:03:06 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 450961E159B; Mon, 1 May 2006 15:33:01 +0930 (CST) Date: Mon, 01 May 2006 06:03:00 -0000 From: Alan Modra To: Ben Elliston Cc: binutils@sourceware.org Subject: Re: PATCH: various gas tidy-ups Message-ID: <20060501060300.GC11597@bubble.grove.modra.org> Mail-Followup-To: Ben Elliston , binutils@sourceware.org References: <20060501044928.GA15768@ozlabs.au.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060501044928.GA15768@ozlabs.au.ibm.com> User-Agent: Mutt/1.4i X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00004.txt.bz2 On Mon, May 01, 2006 at 02:49:28PM +1000, Ben Elliston wrote: > * listing.c (listing_listing): Remove useless loop. > * macro.c (macro_expand): Remove is_positional local variable. > * read.c (s_comm_internal): Simplify `if' condition 1 || x -> 1 > and simplify surrounding expressions, where possible. > (assign_symbol): Likewise. > (s_weakref): Likewise. > * symbols.c (colon): Likewise. OK mainline. -- Alan Modra IBM OzLabs - Linux Technology Centre