From: Ben Elliston <bje@au1.ibm.com>
To: binutils@sourceware.org
Subject: PATCH: off-by-one error in gas/sb.c
Date: Tue, 02 May 2006 01:44:00 -0000 [thread overview]
Message-ID: <20060502014522.GA1045@ozlabs.au.ibm.com> (raw)
While converting an assertion of the form `if (cond) abort ();' to use
assert (), I noticed an off-by-one error in sb_build.
free_list is a variable of type sb_list_vector. An sb_list_vector is
essentially a fixed array of pointers to sb_elements. The dimension
of that array is controlled by sb_max_power_two in sb.h.
The array is indexed by `size' just beneath the assertion, so the
index had better be less than sb_max_power_two, not less than or equal
to it! Okay for mainline?
Ben
Index: sb.c
===================================================================
RCS file: /cvs/src/src/gas/sb.c,v
retrieving revision 1.12
diff -u -p -r1.12 sb.c
--- sb.c 18 May 2005 05:40:07 -0000 1.12
+++ sb.c 2 May 2006 01:38:26 -0000
@@ -66,8 +66,7 @@ sb_build (sb *ptr, int size)
/* See if we can find one to allocate. */
sb_element *e;
- if (size > sb_max_power_two)
- abort ();
+ assert (size < sb_max_power_two);
e = free_list.size[size];
if (!e)
next reply other threads:[~2006-05-02 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 1:44 Ben Elliston [this message]
2006-05-02 1:45 ` Ben Elliston
2006-05-02 2:50 ` Alan Modra
2006-05-02 3:38 ` Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502014522.GA1045@ozlabs.au.ibm.com \
--to=bje@au1.ibm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).