public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H. J. Lu" <hjl@lucon.org>
To: Nick Clifton <nickc@redhat.com>
Cc: Christian Joensson <christian.joensson@gmail.com>,
		binutils <binutils@sources.redhat.com>
Subject: Re: current binutils trunk failures on cygwin
Date: Tue, 02 May 2006 13:27:00 -0000	[thread overview]
Message-ID: <20060502132706.GA10201@lucon.org> (raw)
In-Reply-To: <44574D95.8020903@redhat.com>

On Tue, May 02, 2006 at 01:16:21PM +0100, Nick Clifton wrote:
> Hi H.J.
> 
> >>>FAIL: copy with seting section flags 2
> >
> >objcopy --set-section-flags .text=alloc,data
> >
> >doesn't work on COFF. Someone needs to fix it or I can make it ELF
> >only.
> 
> It does work with COFF targets (eg alpha-linuxecoff).  The problem is PE 
> based targets where there is code to ensure that certain named sections 
> (eg .text) are given specific section flags.  This is in order to comply 
> with the PE spec, so really this is not a bug, but a feature.
> 
> So I am going to apply the attached patch to resolve this problem by 
> changing the name of the section involved from .text to foo.  Actually 
> it does not resolve the problem for AOUT based targets since they do not 
> support arbitrarily named sections, so the test is just marked as 
> unsupported for them.  But I think that skipping AOUT targets is better 
> than skipping PE targets.
> 

I chose .text on purpose since we didn't say --set-section-flags
doesn't work on certain sections. copy-1.d already has a non-standard
section. I would prefer to add a new test and make copy-2.d ELF only.

H.J.

  reply	other threads:[~2006-05-02 13:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-29  0:52 Christian Joensson
2006-05-01 12:43 ` Christian Joensson
2006-05-01 14:08   ` H. J. Lu
2006-05-01 14:37     ` Christian Joensson
2006-05-02 12:16     ` Nick Clifton
2006-05-02 13:27       ` H. J. Lu [this message]
2006-05-02 15:31         ` Nick Clifton
2006-05-02 17:15           ` H. J. Lu
2006-05-03 14:20             ` H. J. Lu
2006-05-03 15:01             ` Nick Clifton
2006-05-03 16:01               ` H. J. Lu
2006-05-03 16:02               ` Dave Korn
2006-05-03 16:51                 ` H. J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060502132706.GA10201@lucon.org \
    --to=hjl@lucon.org \
    --cc=binutils@sources.redhat.com \
    --cc=christian.joensson@gmail.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).