From: Ben Elliston <bje@au1.ibm.com>
To: binutils@sourceware.org
Subject: PATCH: last of the gas tidy-ups
Date: Tue, 09 May 2006 06:53:00 -0000 [thread overview]
Message-ID: <20060509043109.GA23782@ozlabs.au.ibm.com> (raw)
This is the last of my stray binutils patches that have been lurking
in my tree. Okay for mainline?
2006-05-09 Ben Elliston <bje@au.ibm.com>
* expr.c (operand): Remove `if (0 && ..)' statement and
subsequently unused target_op label. Collapse `if (1 || ..)'
statement.
* app.c (do_scrub_chars): Remove unused case 0, as it is handled
separately above the switch.
Index: expr.c
===================================================================
RCS file: /cvs/src/src/gas/expr.c,v
retrieving revision 1.65
diff -u -p -r1.65 expr.c
--- expr.c 4 Apr 2006 08:04:57 -0000 1.65
+++ expr.c 9 May 2006 04:29:01 -0000
@@ -1003,11 +1003,6 @@ operand (expressionS *expressionP, enum
case '-':
case '+':
{
- /* Do not accept ++e or --e as +(+e) or -(-e)
- Disabled, since the preprocessor removes whitespace. */
- if (0 && (c == '-' || c == '+') && *input_line_pointer == c)
- goto target_op;
-
operand (expressionP, mode);
if (expressionP->X_op == O_constant)
{
@@ -1291,7 +1286,6 @@ operand (expressionS *expressionP, enum
}
else
{
- target_op:
/* Let the target try to parse it. Success is indicated by changing
the X_op field to something other than O_absent and pointing
input_line_pointer past the expression. If it can't parse the
@@ -1552,11 +1546,7 @@ operator (int *num_chars)
case '+':
case '-':
- /* Do not allow a++b and a--b to be a + (+b) and a - (-b)
- Disabled, since the preprocessor removes whitespace. */
- if (1 || input_line_pointer[1] != c)
- return op_encoding[c];
- return O_illegal;
+ return op_encoding[c];
case '<':
switch (input_line_pointer[1])
Index: app.c
===================================================================
RCS file: /cvs/src/src/gas/app.c,v
retrieving revision 1.34
diff -u -p -r1.34 app.c
--- app.c 10 Mar 2006 10:57:18 -0000 1.34
+++ app.c 9 May 2006 04:29:03 -0000
@@ -888,9 +888,6 @@ do_scrub_chars (int (*get) (char *, int)
switch (state)
{
- case 0:
- state++;
- goto recycle; /* Punted leading sp */
case 1:
/* We can arrive here if we leave a leading whitespace
character at the beginning of a line. */
next reply other threads:[~2006-05-09 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 6:53 Ben Elliston [this message]
2006-05-09 8:06 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060509043109.GA23782@ozlabs.au.ibm.com \
--to=bje@au1.ibm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).