From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sourceware.org
Subject: pr2342
Date: Wed, 10 May 2006 10:00:00 -0000 [thread overview]
Message-ID: <20060510044552.GC22090@bubble.grove.modra.org> (raw)
I don't know what to do about pr2342. I'm inclined to revert my
2006-02-16 bfd/elflink.c change for 2.17, simply because I haven't
developed a proper fix. In any case, zeroing out debug fields pointing
into discarded sections has its own problems. eg, in some sections, a
zero is a list terminator so poking zeros in the middle of a list isn't
correct. We really need to edit the debug info, and fix all the refs.
PR 2342
* elflink.c (_bfd_elf_default_action_discarded): Revert 2006-02-16.
Index: bfd/elflink.c
===================================================================
RCS file: /cvs/src/src/bfd/elflink.c,v
retrieving revision 1.211
diff -u -p -r1.211 elflink.c
--- bfd/elflink.c 2 May 2006 01:41:20 -0000 1.211
+++ bfd/elflink.c 10 May 2006 04:24:37 -0000
@@ -6758,7 +6758,7 @@ unsigned int
_bfd_elf_default_action_discarded (asection *sec)
{
if (sec->flags & SEC_DEBUGGING)
- return 0;
+ return PRETEND;
if (strcmp (".eh_frame", sec->name) == 0)
return 0;
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next reply other threads:[~2006-05-10 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 10:00 Alan Modra [this message]
2006-05-10 17:02 ` pr2342 H. J. Lu
2006-05-11 8:56 ` pr2342 Alan Modra
2006-05-12 20:54 ` pr2342 H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510044552.GC22090@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).