From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46067-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 1740 invoked by alias); 23 May 2006 00:08:57 -0000
Received: (qmail 1725 invoked by uid 22791); 23 May 2006 00:08:56 -0000
X-Spam-Check-By: sourceware.org
Received: from bender.bawue.de (HELO bender.bawue.de) (193.7.176.20)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 23 May 2006 00:08:54 +0000
Received: from lagash (88-106-136-76.dynamic.dsl.as9105.com [88.106.136.76]) 	(using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) 	(No client certificate requested) 	by bender.bawue.de (Postfix) with ESMTP 	id 613F64494B; Tue, 23 May 2006 02:08:52 +0200 (MEST)
Received: from ths by lagash with local (Exim 4.62) 	(envelope-from <ths@networkno.de>) 	id 1FiKRz-0000CD-DC; Tue, 23 May 2006 01:08:39 +0100
Date: Tue, 23 May 2006 05:27:00 -0000
From: Thiemo Seufer <ths@networkno.de>
To: Eric Christopher <echristo@apple.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Better checking of ISA/ASE/ABI options for MIPS gas
Message-ID: <20060523000839.GB9061@networkno.de>
References: <20060522202627.GE30254@networkno.de> <9C4668ED-B9FB-4A18-BCF4-CA7F5DFFE0E1@apple.com> <20060522234641.GA9061@networkno.de> <A9F8D906-B293-44CF-A220-E4E1798F60F0@apple.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A9F8D906-B293-44CF-A220-E4E1798F60F0@apple.com>
User-Agent: Mutt/1.5.11+cvs20060403
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-05/txt/msg00393.txt.bz2

Eric Christopher wrote:
[snip]
> >>And why change the table to include default extensions for the cpu?
> >
> >To handle them the same way as the ISA. This is for ASEs which are
> >always implemented in that particular CPU.
> 
> You'll need to look through the code and make sure we aren't depending on
> the value not being zero somewhere then.

I changed the test for is_isa in mips_cpu_info_from_isa() to
(flags & MIPS_CPU_IS_ISA). mips_cpu_info_from_isa() is the only user.

> To be honest I'd just prefer another field for "default ASEs".

  a) This would bloat the table by another field to initialise.
  b) There is no generic ISA with an ASE, both uses are mutually
     exclusive.


Thiemo