From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-46120-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 12848 invoked by alias); 24 May 2006 23:53:16 -0000
Received: (qmail 12839 invoked by uid 22791); 24 May 2006 23:53:15 -0000
X-Spam-Check-By: sourceware.org
Received: from omta02ps.mx.bigpond.com (HELO omta02ps.mx.bigpond.com) (144.140.83.154)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 May 2006 23:53:13 +0000
Received: from grove.modra.org ([144.136.172.108])           by omta02ps.mx.bigpond.com with ESMTP           id <20060524235310.WMTE29751.omta02ps.mx.bigpond.com@grove.modra.org>;           Wed, 24 May 2006 23:53:10 +0000
Received: by bubble.grove.modra.org (Postfix, from userid 500) 	id DCA921E4D90; Thu, 25 May 2006 09:23:09 +0930 (CST)
Date: Thu, 25 May 2006 03:48:00 -0000
From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: ld/1485: --enable-targets=all doesn't work for 64bit target
Message-ID: <20060524235309.GB25824@bubble.grove.modra.org>
Mail-Followup-To: "H. J. Lu" <hjl@lucon.org>, 	binutils@sources.redhat.com
References: <20060524172325.GA4375@lucon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060524172325.GA4375@lucon.org>
User-Agent: Mutt/1.4i
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-05/txt/msg00446.txt.bz2

On Wed, May 24, 2006 at 10:23:25AM -0700, H. J. Lu wrote:
> --- ld/configure.in.64	2006-04-14 14:44:46.000000000 -0700
> +++ ld/configure.in	2006-05-24 10:16:18.000000000 -0700
> @@ -169,6 +169,11 @@ do
>        EMUL=$targ_emul
>      fi
>  
> +    . ${srcdir}/../bfd/config.bfd
> +    case "${targ_defvec}-${targ_selvecs}" in
> +    *elf64*) want64=true;;
> +    esac
> +
>      for i in $targ_emul $targ_extra_emuls $targ_extra_libpath; do
>  	case " $all_emuls " in
>  	*" e${i}.o "*) ;;

Please don't add the case statement here.  Instead, set want64 in
config.bfd on each target that has a 64-bit BFD, ie. everything inside
#ifdef BFD64.  Patch preapproved with that change.  I know there are
some targets that are 64-bit but don't have "elf64" support.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre