From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5459 invoked by alias); 25 May 2006 03:18:06 -0000 Received: (qmail 5450 invoked by uid 22791); 25 May 2006 03:18:05 -0000 X-Spam-Check-By: sourceware.org Received: from omta03ps.mx.bigpond.com (HELO omta03ps.mx.bigpond.com) (144.140.82.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 25 May 2006 03:18:01 +0000 Received: from grove.modra.org ([144.136.172.108]) by omta03ps.mx.bigpond.com with ESMTP id <20060525031758.HRHF17135.omta03ps.mx.bigpond.com@grove.modra.org>; Thu, 25 May 2006 03:17:58 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id E806E1E4D95; Thu, 25 May 2006 12:47:57 +0930 (CST) Date: Thu, 25 May 2006 05:55:00 -0000 From: Alan Modra To: "H. J. Lu" Cc: binutils@sources.redhat.com, joern.rennecke@superh.com, aoliva@redhat.com, kkojima@rr.iij4u.or.jp Subject: Re: Should sh-*-* enable 64bit targets? Message-ID: <20060525031757.GE25824@bubble.grove.modra.org> Mail-Followup-To: "H. J. Lu" , binutils@sources.redhat.com, joern.rennecke@superh.com, aoliva@redhat.com, kkojima@rr.iij4u.or.jp References: <20060524172325.GA4375@lucon.org> <20060524235309.GB25824@bubble.grove.modra.org> <20060525005822.GA7197@lucon.org> <20060525011825.GD25824@bubble.grove.modra.org> <20060525023303.GA8100@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060525023303.GA8100@lucon.org> User-Agent: Mutt/1.4i X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00450.txt.bz2 On Wed, May 24, 2006 at 07:33:03PM -0700, H. J. Lu wrote: > On Thu, May 25, 2006 at 10:48:25AM +0930, Alan Modra wrote: > > On Wed, May 24, 2006 at 05:58:22PM -0700, H. J. Lu wrote: > > > sh-*-linux*) > > > targ_defvec=bfd_elf32_shblin_vec > > > targ_selvecs=bfd_elf32_shlin_vec > > > -#ifdef BFD64 > > > - targ_selvecs="${targ_selvecs} bfd_elf32_sh64lin_vec bfd_elf32_sh64blin_vec bfd_elf64_sh64lin_vec bfd_elf64_sh64blin_vec" > > > -#endif > > > + targ64_selvecs="bfd_elf32_sh64lin_vec bfd_elf32_sh64blin_vec bfd_elf64_sh64lin_vec bfd_elf64_sh64blin_vec" > > > ;; > > > > You should have set want64=true here and in the other sh cases you > > changed to use targ64_selvecs. > > I am not sure what the original intention was. I assume they wanted > to enable 64bit targets if BFD was 64bit. That is what my change does > by setting targ64_selvecs. #ifdef in a shell script is just a comment. So the original config.bfd always included the 64-bit sh targets in target_selvecs. Your patch to use targ64_selvecs changes that behaviour. Please add want64=true. -- Alan Modra IBM OzLabs - Linux Technology Centre