From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1759 invoked by alias); 25 May 2006 05:01:14 -0000 Received: (qmail 1738 invoked by uid 22791); 25 May 2006 05:01:12 -0000 X-Spam-Check-By: sourceware.org Received: from CPE-144-136-172-108.sa.bigpond.net.au (HELO grove.modra.org) (144.136.172.108) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 25 May 2006 05:01:10 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id C51B81E4D93; Thu, 25 May 2006 14:31:07 +0930 (CST) Date: Thu, 25 May 2006 13:28:00 -0000 From: Alan Modra To: Julian Brown Cc: binutils@sourceware.org, Richard Earnshaw , Paul Brook Subject: Re: [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects Message-ID: <20060525050107.GF25824@bubble.grove.modra.org> Mail-Followup-To: Julian Brown , binutils@sourceware.org, Richard Earnshaw , Paul Brook References: <44746112.1000203@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44746112.1000203@codesourcery.com> User-Agent: Mutt/1.4i X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00454.txt.bz2 On Wed, May 24, 2006 at 02:35:14PM +0100, Julian Brown wrote: > * objcopy.c (filter_symbols): Filter out section symbols for > sections which are being stripped and their associated relocation > sections. Call bfd_copy_private_symbol_data for each symbol which > passes the filter. I think this should be fixed in elf.c:elf_map_symbols by throwing away any bad section syms. That way we keep (more) elf specific code out of objcopy.c. I'll take a look at it. -- Alan Modra IBM OzLabs - Linux Technology Centre