From: Daniel Jacobowitz <drow@false.org>
To: Ben Elliston <bje@air.net.au>
Cc: Richard Sandiford <richard@codesourcery.com>, binutils@sourceware.org
Subject: Re: Coldfire fmovem fixes
Date: Thu, 25 May 2006 16:53:00 -0000 [thread overview]
Message-ID: <20060525132811.GB31002@nevyn.them.org> (raw)
In-Reply-To: <20060525155134.A16253@mailhub.air.net.au>
On Thu, May 25, 2006 at 03:51:34PM +1000, Ben Elliston wrote:
> Hi Richard
>
> > include/opcodes/
> > * m68k.h (mcf_mask): Define.
> >
> > opcodes/
> > * m68k-opc.c (m68k_opcodes): Fix the masks of the Coldfire fmovemd
> > and fmovem entries. Put register list entries before immediate
> > mask entries. Use "l" rather than "L" in the fmovem entries.
> > * m68k-dis.c (match_insn_m68k): Remove the PRIV argument and work it
> > out from INFO.
> > (m68k_scan_mask): New function, split out from...
> > (print_insn_m68k): ...here. If no architecture has been set,
> > first try printing an m680x0 instruction, then try a Coldfire one.
> >
> > gas/testsuite/
> > * gas/m68k/mcf-fpu.s: Add fmovemd and fmovem instructions.
> > * gas/m68k/mcf-fpu.d: Adjust accordingly.
>
> OK. I'm undecided about whether this warrants committing to the 2.17
> branch. I'll leave that to Daniel to decide.
Seems reasonable to me; this is OK for the branch.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-05-25 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060524004418.GA1912@ozlabs.au.ibm.com>
2006-05-25 13:57 ` Ben Elliston
2006-05-25 16:53 ` Daniel Jacobowitz [this message]
2006-05-22 15:59 Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525132811.GB31002@nevyn.them.org \
--to=drow@false.org \
--cc=binutils@sourceware.org \
--cc=bje@air.net.au \
--cc=richard@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).