From: "H. J. Lu" <hjl@lucon.org>
To: Nick Clifton <nickc@redhat.com>,
binutils@sources.redhat.com, discuss@x86-64.org
Subject: Re: PATCH: Change x86-64 maximum page size to 2MB
Date: Sat, 27 May 2006 00:47:00 -0000 [thread overview]
Message-ID: <20060526030324.GA17436@lucon.org> (raw)
In-Reply-To: <20060526024303.GA16636@nevyn.them.org>
On Thu, May 25, 2006 at 10:43:03PM -0400, Daniel Jacobowitz wrote:
> On Thu, May 25, 2006 at 04:10:19PM -0700, H. J. Lu wrote:
> > On Fri, May 19, 2006 at 10:12:01AM +0100, Nick Clifton wrote:
> > > Hi H. J.
> > >
> > > >The current x86-64 maximum page size is 1MB. With the future
> > > >development, 2MB is better for performance. Using 2MB won't break
> > > >anything, except for up to 2MB gap in virtual address space per file,
> > > >instead of 1MB. x86-64 has 48 bits in virtual address space. It
> > > >shouldn't be an issue for most applications. I have a patch:
> > > >
> > > >http://sourceware.org/ml/binutils/2005-05/msg00644.html
> > > >
> > > >which can be used to implement "-z max-page-size=xxxx" so that people
> > > >can control maximum page size at the link time if they prefer different
> > > >maximum page size.
> > >
> > > This seems to be perfectly reasonable.
> >
> > I tested this patch on gcc, glibc, 2.4 and 2.6 kernels. I will check
> > it in shortly.
>
> If you do this without setting ELF_MINPAGESIZE, won't BFD start to
> reject some files?
>
> It doesn't happen obviously, they'll just get corrupted on objcopy;
> see the one use of ->minpagesize.
>
Thanks. I am checking in this patch. I will add a testcase once we can
use a different maximum page size.
H.J.
---
2006-05-25 H.J. Lu <hongjiu.lu@intel.com>
* elf64-x86-64.c (ELF_MINPAGESIZE): Set to 0x100000.
--- bfd/elf64-x86-64.c.min 2006-05-25 19:54:47.000000000 -0700
+++ bfd/elf64-x86-64.c 2006-05-25 19:56:07.000000000 -0700
@@ -3631,6 +3631,7 @@ static const struct bfd_elf_special_sect
#define ELF_ARCH bfd_arch_i386
#define ELF_MACHINE_CODE EM_X86_64
#define ELF_MAXPAGESIZE 0x200000
+#define ELF_MINPAGESIZE 0x100000
#define elf_backend_can_gc_sections 1
#define elf_backend_can_refcount 1
next prev parent reply other threads:[~2006-05-26 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 11:24 RFC: " H. J. Lu
2006-05-19 12:39 ` Nick Clifton
2006-05-22 23:57 ` H. J. Lu
2006-05-24 7:24 ` PATCH: Add "-z max-page-size=xxxx"/"-z common-page-size=xxxx" H. J. Lu
2006-05-31 11:36 ` Nick Clifton
2006-05-26 4:33 ` PATCH: Change x86-64 maximum page size to 2MB H. J. Lu
2006-05-26 21:48 ` Daniel Jacobowitz
2006-05-27 0:47 ` H. J. Lu [this message]
2006-05-27 16:33 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060526030324.GA17436@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
--cc=discuss@x86-64.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).