From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sourceware.org, dj@redhat.com
Subject: Re: Increment
Date: Tue, 06 Jun 2006 04:30:00 -0000 [thread overview]
Message-ID: <20060606030414.GH519@bubble.grove.modra.org> (raw)
In-Reply-To: <m3u07c5uig.fsf@gossamer.airs.com>
On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote:
> bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
> misplaced increment of table->count:
This seems to have fallen through the cracks. Applying the obvious
fix.
* hash.c (bfd_hash_lookup): Correct stray line.
Index: bfd/hash.c
===================================================================
RCS file: /cvs/src/src/bfd/hash.c,v
retrieving revision 1.22
diff -u -p -r1.22 hash.c
--- bfd/hash.c 3 May 2006 04:20:52 -0000 1.22
+++ bfd/hash.c 6 Jun 2006 03:02:53 -0000
@@ -455,7 +455,6 @@ bfd_hash_lookup (struct bfd_hash_table *
if (copy)
{
char *new;
- table->count ++;
new = objalloc_alloc ((struct objalloc *) table->memory, len + 1);
if (!new)
@@ -470,6 +469,7 @@ bfd_hash_lookup (struct bfd_hash_table *
hashp->hash = hash;
hashp->next = table->table[index];
table->table[index] = hashp;
+ table->count++;
if (table->count > table->size * 3 / 4)
{
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2006-06-06 3:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 16:33 Increment Ian Lance Taylor
2006-06-06 4:30 ` Alan Modra [this message]
2006-06-06 10:52 ` Increment Alan Modra
2006-06-07 1:40 ` Increment Thiemo Seufer
2006-06-07 5:02 ` Increment Alan Modra
2006-06-09 13:42 ` Increment Andreas Schwab
2006-06-12 4:32 ` Increment Alan Modra
2006-06-12 10:50 ` Increment Andreas Schwab
2006-06-12 18:53 ` Increment DJ Delorie
2006-06-12 19:13 ` Increment H. J. Lu
2006-06-12 23:55 ` Increment Andreas Schwab
2006-06-13 1:11 ` Increment Alan Modra
2006-06-13 10:52 ` Increment Andreas Schwab
2006-06-13 8:53 ` Increment H. J. Lu
2006-06-13 13:49 ` Increment Andreas Schwab
2006-06-13 14:49 ` Increment Alan Modra
2006-06-13 14:52 ` Increment Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060606030414.GH519@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=dj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).