From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25690 invoked by alias); 6 Jun 2006 03:04:21 -0000 Received: (qmail 25681 invoked by uid 22791); 6 Jun 2006 03:04:21 -0000 X-Spam-Check-By: sourceware.org Received: from omta01sl.mx.bigpond.com (HELO omta01sl.mx.bigpond.com) (144.140.92.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Jun 2006 03:04:19 +0000 Received: from grove.modra.org ([144.136.172.108]) by omta01sl.mx.bigpond.com with ESMTP id <20060606030416.PVRM19512.omta01sl.mx.bigpond.com@grove.modra.org>; Tue, 6 Jun 2006 03:04:16 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 17D431E6DCA; Tue, 6 Jun 2006 12:34:15 +0930 (CST) Date: Tue, 06 Jun 2006 04:30:00 -0000 From: Alan Modra To: binutils@sourceware.org, dj@redhat.com Subject: Re: Increment Message-ID: <20060606030414.GH519@bubble.grove.modra.org> Mail-Followup-To: binutils@sourceware.org, dj@redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00059.txt.bz2 On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote: > bfd_hash_lookup in bfd/hash.c has an incorrectly indented and > misplaced increment of table->count: This seems to have fallen through the cracks. Applying the obvious fix. * hash.c (bfd_hash_lookup): Correct stray line. Index: bfd/hash.c =================================================================== RCS file: /cvs/src/src/bfd/hash.c,v retrieving revision 1.22 diff -u -p -r1.22 hash.c --- bfd/hash.c 3 May 2006 04:20:52 -0000 1.22 +++ bfd/hash.c 6 Jun 2006 03:02:53 -0000 @@ -455,7 +455,6 @@ bfd_hash_lookup (struct bfd_hash_table * if (copy) { char *new; - table->count ++; new = objalloc_alloc ((struct objalloc *) table->memory, len + 1); if (!new) @@ -470,6 +469,7 @@ bfd_hash_lookup (struct bfd_hash_table * hashp->hash = hash; hashp->next = table->table[index]; table->table[index] = hashp; + table->count++; if (table->count > table->size * 3 / 4) { -- Alan Modra IBM OzLabs - Linux Technology Centre