From: Thiemo Seufer <ths@networkno.de>
To: binutils@sourceware.org
Subject: Re: Increment
Date: Wed, 07 Jun 2006 01:40:00 -0000 [thread overview]
Message-ID: <20060606205925.GA9732@networkno.de> (raw)
In-Reply-To: <20060606030414.GH519@bubble.grove.modra.org>
Alan Modra wrote:
> On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote:
> > bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
> > misplaced increment of table->count:
>
> This seems to have fallen through the cracks. Applying the obvious
> fix.
>
> * hash.c (bfd_hash_lookup): Correct stray line.
>
> Index: bfd/hash.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/hash.c,v
> retrieving revision 1.22
> diff -u -p -r1.22 hash.c
> --- bfd/hash.c 3 May 2006 04:20:52 -0000 1.22
> +++ bfd/hash.c 6 Jun 2006 03:02:53 -0000
> @@ -455,7 +455,6 @@ bfd_hash_lookup (struct bfd_hash_table *
> if (copy)
> {
> char *new;
> - table->count ++;
>
> new = objalloc_alloc ((struct objalloc *) table->memory, len + 1);
> if (!new)
> @@ -470,6 +469,7 @@ bfd_hash_lookup (struct bfd_hash_table *
> hashp->hash = hash;
> hashp->next = table->table[index];
> table->table[index] = hashp;
> + table->count++;
>
> if (table->count > table->size * 3 / 4)
> {
This change broke two MIPS (mips-linux) ld testcases, I'm not sure if
this indicates breakage or invalid tests:
/home/ths/gcc/binutils-upstream/head-build/ld/../gas/as-new -EB -32 -KPIC -o tmpdir/dump0.o /home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf/multi-got-1-1.s
/home/ths/gcc/binutils-upstream/head-build/ld/../gas/as-new -EB -32 -KPIC -o tmpdir/dump1.o /home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf/multi-got-1-2.s
./ld-new -L/home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf -melf32btsmip -shared -o tmpdir/dump tmpdir/dump0.o tmpdir/dump1.o
/home/ths/gcc/binutils-upstream/head-build/ld/../binutils/readelf -d -r tmpdir/dump > tmpdir/dump.out
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_3817$"
line "000c447c 00200b03 R_MIPS_REL32 0009ffdc sym_2_4428"
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_1864$"
line "000c99ac 00200c03 R_MIPS_REL32 0009fa64 sym_2_4078"
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_771$"
line "000c6380 00200d03 R_MIPS_REL32 0009c1b4 sym_2_450"
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_4264$"
line "000ca434 00200e03 R_MIPS_REL32 0009c120 sym_2_413"
[snip many more lines]
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_2228$"
line "000c8f48 00400903 R_MIPS_REL32 0009fdb4 sym_2_4290"
regexp_diff match failure
regexp "^^[0-9a-f]+ [0-9a-f]+ R_MIPS_REL32 [0-9a-f]+ sym_2_2140$"
line "000cb328 00400a03 R_MIPS_REL32 0009f8a4 sym_2_3966"
FAIL: MIPS multi-got-1
[snip]
/home/ths/gcc/binutils-upstream/head-build/ld/../gas/as-new -o tmpdir/tls-multi-got-1-1.o -EB -march=mips1 -32 -KPIC /home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf/tls-multi-got-1-1.s
/home/ths/gcc/binutils-upstream/head-build/ld/../gas/as-new -o tmpdir/tls-multi-got-1-2.o -EB -march=mips1 -32 -KPIC /home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf/tls-multi-got-1-2.s
/home/ths/gcc/binutils-upstream/head-build/ld/ld-new -o tmpdir/tlslib-multi.so -L/home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf -shared -melf32btsmip -T mips-lib.ld tmpdir/tls-multi-got-1-1.o tmpdir/tls-multi-got-1-2.o
/home/ths/gcc/binutils-upstream/head-build/ld/../binutils/readelf -d -r tmpdir/tlslib-multi.so > dump.out
regexp_diff match failure
regexp "^001495d8 00000c2f R_MIPS_TLS_TPREL3 00000004 tlsvar_ie$"
line "001495d8 00000b2f R_MIPS_TLS_TPREL3 00000004 tlsvar_ie"
regexp_diff match failure
regexp "^0013f950 00000c2f R_MIPS_TLS_TPREL3 00000004 tlsvar_ie$"
line "0013f950 00000b2f R_MIPS_TLS_TPREL3 00000004 tlsvar_ie"
regexp_diff match failure
regexp "^00135fcc 00000e03 R_MIPS_REL32 000e0a4c sym_2_8355$"
line "00143f7c 00000e03 R_MIPS_REL32 000d8048 sym_1_9526"
regexp_diff match failure
regexp "^001424ac 00000f03 R_MIPS_REL32 000d3594 sym_1_4745$"
line "00143768 00000f03 R_MIPS_REL32 000d66a4 sym_1_7885"
extra regexps in /home/ths/gcc/binutils-upstream/head/ld/testsuite/ld-mips-elf/tls-multi-got-1.r starting with "^001369b0 004e2c03 R_MIPS_REL32 000da930 sym_2_2140$"
EOF from dump.out
FAIL: Shared library with multiple GOTs and TLS
next prev parent reply other threads:[~2006-06-06 21:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 16:33 Increment Ian Lance Taylor
2006-06-06 4:30 ` Increment Alan Modra
2006-06-06 10:52 ` Increment Alan Modra
2006-06-07 1:40 ` Thiemo Seufer [this message]
2006-06-07 5:02 ` Increment Alan Modra
2006-06-09 13:42 ` Increment Andreas Schwab
2006-06-12 4:32 ` Increment Alan Modra
2006-06-12 10:50 ` Increment Andreas Schwab
2006-06-12 18:53 ` Increment DJ Delorie
2006-06-12 19:13 ` Increment H. J. Lu
2006-06-12 23:55 ` Increment Andreas Schwab
2006-06-13 1:11 ` Increment Alan Modra
2006-06-13 10:52 ` Increment Andreas Schwab
2006-06-13 8:53 ` Increment H. J. Lu
2006-06-13 13:49 ` Increment Andreas Schwab
2006-06-13 14:49 ` Increment Alan Modra
2006-06-13 14:52 ` Increment Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060606205925.GA9732@networkno.de \
--to=ths@networkno.de \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).