From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21688 invoked by alias); 9 Jun 2006 00:04:21 -0000 Received: (qmail 21680 invoked by uid 22791); 9 Jun 2006 00:04:20 -0000 X-Spam-Check-By: sourceware.org Received: from bender.bawue.de (HELO bender.bawue.de) (193.7.176.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Jun 2006 00:04:18 +0000 Received: from lagash (88-106-172-197.dynamic.dsl.as9105.com [88.106.172.197]) (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by bender.bawue.de (Postfix) with ESMTP id 10A51450F6; Fri, 9 Jun 2006 02:04:16 +0200 (MEST) Received: from ths by lagash with local (Exim 4.62) (envelope-from ) id 1FoUU3-00006R-3L; Fri, 09 Jun 2006 01:04:15 +0100 Date: Fri, 09 Jun 2006 01:16:00 -0000 From: Thiemo Seufer To: David Daney Cc: binutils@sourceware.org Subject: Re: [PATCH] (version 2) Change MIPS linker stubs to allow for more than 2^15 symbols. Message-ID: <20060609000415.GF25431@networkno.de> References: <4488A29D.5040100@avtrex.com> <20060608230248.GE25431@networkno.de> <4488AEBC.6020604@avtrex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4488AEBC.6020604@avtrex.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00118.txt.bz2 David Daney wrote: > Thiemo Seufer wrote: > >David Daney wrote: > >>--- 8020,8061 ---- > >> MIPS_ELF_STUB_SECTION_NAME (dynobj)); > >> BFD_ASSERT (s != NULL); > >> > >>! BFD_ASSERT ((MIPS_FUNCTION_STUB_SIZE (info) == 20) > >>! || (h->dynindx <= 65536)); > >>! > >>! /* Values up to 2^31 - 1 are allowed. Larger values would cause > >>! * sign extension at runtime in the stub, resulting in a negative > >>! * index value. > >>! */ > >>! if (h->dynindx & 0x80000000) > >> return FALSE; > >> > >> /* Fill the stub. */ > >>! idx = 0; > >>! bfd_put_32 (output_bfd, STUB_LW (output_bfd), stub + idx); > >>! idx += 4; > >>! bfd_put_32 (output_bfd, STUB_MOVE (output_bfd), stub + idx); > >>! idx += 4; > >>! if (MIPS_FUNCTION_STUB_SIZE (info) == 20) > >>! { > >>! bfd_put_32 (output_bfd, STUB_LUI ((h->dynindx >> 16 ) & > >>0xffff), > > > > > >Formatting. Otherwise ok for trunk. > > > > I try to keep current on GNU coding standards, but could you tell me > which aspect of the formatting is non-compliant? The dangling closing parenthesis. And, as Daniel noted, the comment formatting. Thiemo