public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: binutils@sources.redhat.com
Subject: Re: PATCH: Remove InvMem from MMX/SSE instructions
Date: Sun, 16 Jul 2006 03:54:00 -0000	[thread overview]
Message-ID: <20060716035356.GG18571@bubble.grove.modra.org> (raw)
In-Reply-To: <20060713230903.GA24686@lucon.org>

On Thu, Jul 13, 2006 at 04:09:03PM -0700, H. J. Lu wrote:
> http://sourceware.org/ml/binutils/2001-05/msg00065.html
> http://sourceware.org/ml/binutils/2001-05/msg00187.html
> 
> use InvMem on source operand to indicate that it must be register. 
> I don't believe it is correct since RegYYY won't match memory anyway
> and InvMem is used to indicate how operand should be encoded. This
> patch removes it.

It's true that the way the code is currently written that removing this
flag will not change the insn encoding.  All InvMem does on *source*
operands of these reg->reg insns is document that the register is
encoded in the regmem field of the modrm byte.  So why do you want to
remove documentation?  There is certainly nothing wrong with InvMem on
these operands.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

  reply	other threads:[~2006-07-16  3:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-13 23:09 H. J. Lu
2006-07-16  3:54 ` Alan Modra [this message]
2006-07-16 17:13   ` H. J. Lu
2006-07-17  8:49     ` Alan Modra
2006-07-17 20:12       ` H. J. Lu
2006-07-17 21:14         ` H. J. Lu
2006-07-18 20:01           ` RFC: Use long long in x86 assembler H. J. Lu
2006-07-18 22:48             ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060716035356.GG18571@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=hjl@lucon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).